From: Stefan Beller <sbeller@google.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Michael Haggerty <mhagger@alum.mit.edu>,
Junio C Hamano <gitster@pobox.com>,
"git@vger.kernel.org" <git@vger.kernel.org>,
Ronnie Sahlberg <sahlberg@google.com>
Subject: Re: [PATCH] t1402: check to delete broken refs
Date: Tue, 25 Nov 2014 16:42:20 -0800 [thread overview]
Message-ID: <CAGZ79kao0CpeidBzVL4O-4jfNd7nGbOJwtvsJCEgOjb370z8uw@mail.gmail.com> (raw)
In-Reply-To: <20141126003506.GA19239@google.com>
On Tue, Nov 25, 2014 at 4:35 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:
> Hi,
>
> Stefan Beller wrote:
>
>> This was also part of the ongoing series from Ronnie.
>> But I think the patch in this form is rather independant,
>> documenting the current state of "git branch -d", so it's
>> fine to have it in now.
>
> Is there a patch adding the feature this patch describes that this
> could be squashed into?
I have extracted it actually from a patch, which it was part of.
I want to send as much uncontroversial stuff to the list, before I try another
round of the larger reflog transactions series.
For now this test just documents, how git branch is behaving differently
from its desired behavior. So it is also a subtle proposal how the desired
behavior should look like. (Deleting broken branches without further
questioning, flags or other magic incantations)
>
>> t/t1402-check-ref-format.sh | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>
> This doesn't have anything to do with check-ref-format --- it's about
> how easy it is to recover from a repository with corrupt files in it.
> Would it fit somewhere like t3200-branch.sh?
I'll look into placing this test in a more appropriate spot.
next prev parent reply other threads:[~2014-11-26 0:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-25 22:56 [PATCH] t1402: check to delete broken refs Stefan Beller
2014-11-26 0:35 ` Jonathan Nieder
2014-11-26 0:42 ` Stefan Beller [this message]
2014-11-26 0:59 ` [PATCHv2] branch -d: test if we can " Stefan Beller
2014-11-26 8:49 ` Michael Haggerty
2014-11-26 18:43 ` Junio C Hamano
2014-11-26 5:05 ` [PATCH] t1402: check to " Torsten Bögershausen
2014-11-26 18:37 ` [PATCHv3] branch -d: test if we can " Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGZ79kao0CpeidBzVL4O-4jfNd7nGbOJwtvsJCEgOjb370z8uw@mail.gmail.com \
--to=sbeller@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=mhagger@alum.mit.edu \
--cc=sahlberg@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).