From: Stefan Beller <sbeller@google.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: git <git@vger.kernel.org>,
Jonathan Tan <jonathantanmy@google.com>,
Jeff Hostetler <jeffhost@microsoft.com>
Subject: Re: [PATCH] partial-clone: render design doc using asciidoc
Date: Tue, 14 Aug 2018 16:18:02 -0700 [thread overview]
Message-ID: <CAGZ79kb+f8-z+iVNFurSt1ezGNTonJa0ZZbFNhtbfKvCSaDBxA@mail.gmail.com> (raw)
In-Reply-To: <20180814231232.GI142615@aiede.svl.corp.google.com>
On Tue, Aug 14, 2018 at 4:12 PM Jonathan Nieder <jrnieder@gmail.com> wrote:
>
> Hi,
>
> Stefan Beller wrote:
> > On Tue, Aug 14, 2018 at 3:28 PM Jonathan Nieder <jrnieder@gmail.com> wrote:
>
> >> repack in GC has been updated to not touch promisor
> >> packfiles at all, and to only repack other objects.
> >
> > We'd need to adapt this documentation in Jonathans series?
>
> Yes, or in a separate patch.
>
> >> -[0] https://bugs.chromium.org/p/git/issues/detail?id=2
> >> - Chromium work item for: Partial Clone
> >> +[0] https://crbug.com/git/2
> >> + Bug#2: Partial Clone
> >
> > This is more than a formatting fix (I did not quite check the rest,
> > but this stood out), but some change to the actual content?
>
> "git show --word-diff" tells me it's the only place that touched
> wording. If you'd like, I can send it as a separate, preparatory
> patch.
--word-diff is even nicer than -w which is fine for all except the links.
If you are inclined to resend, please do separate, but I do not
insist on it.
Thanks,
Stefan
prev parent reply other threads:[~2018-08-14 23:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-14 22:28 [PATCH] partial-clone: render design doc using asciidoc Jonathan Nieder
2018-08-14 23:00 ` Stefan Beller
2018-08-14 23:12 ` Jonathan Nieder
2018-08-14 23:18 ` Stefan Beller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGZ79kb+f8-z+iVNFurSt1ezGNTonJa0ZZbFNhtbfKvCSaDBxA@mail.gmail.com \
--to=sbeller@google.com \
--cc=git@vger.kernel.org \
--cc=jeffhost@microsoft.com \
--cc=jonathantanmy@google.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).