From: Stefan Beller <sbeller@google.com>
To: "git@vger.kernel.org" <git@vger.kernel.org>,
Michael Haggerty <mhagger@alum.mit.edu>,
Jonathan Nieder <jrnieder@gmail.com>,
ronnie sahlberg <ronniesahlberg@gmail.com>,
Junio C Hamano <gitster@pobox.com>
Cc: Stefan Beller <sbeller@google.com>
Subject: Re: [PATCH 0/8] Making reflog modifications part of the transactions API
Date: Mon, 8 Dec 2014 12:05:26 -0800 [thread overview]
Message-ID: <CAGZ79kb1yiSENO+uANdeOKtcSCZgZA3UXSdE2F5PBA49erh2Jw@mail.gmail.com> (raw)
In-Reply-To: <1417833995-25687-1-git-send-email-sbeller@google.com>
So I reviewed and examined this series and run into some problems.
How do we view an empty reflog, i.e. an empty file at logs/refs/heads/master?
I was told this is not a valid state for a reflog. However even the
test suite sometimes
produces an empty reflog files.
Below there is a patch, which highlights the empty reflog when running
t1301.sh verbosely.
---
t/t1301-shared-repo.sh | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/t/t1301-shared-repo.sh b/t/t1301-shared-repo.sh
index de42d21..6a35fc0 100755
--- a/t/t1301-shared-repo.sh
+++ b/t/t1301-shared-repo.sh
@@ -113,7 +113,9 @@ done
test_expect_success POSIXPERM 'git reflog expire honors
core.sharedRepository' '
git config core.sharedRepository group &&
- git reflog expire --all &&
+ git reflog master &&
+ git reflog expire --all --verbose &&
+ git reflog master &&
actual="$(ls -l .git/logs/refs/heads/master)" &&
case "$actual" in
-rw-rw-*)
--
2.2.0
next prev parent reply other threads:[~2014-12-08 20:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-06 2:46 [PATCH 0/8] Making reflog modifications part of the transactions API Stefan Beller
2014-12-06 2:46 ` [PATCH 1/8] refs.c: let fprintf handle the formatting Stefan Beller
2014-12-06 2:46 ` [PATCH 2/8] refs.c: rename the transaction functions Stefan Beller
2014-12-11 21:42 ` Junio C Hamano
2014-12-11 21:48 ` Stefan Beller
2014-12-06 2:46 ` [PATCH 3/8] refs.c: rename transaction.updates to transaction.ref_updates Stefan Beller
2014-12-06 2:46 ` [PATCH 4/8] refs.c: add transaction function to append to the reflog Stefan Beller
2014-12-11 21:50 ` Junio C Hamano
2014-12-06 2:46 ` [PATCH 5/8] refs.c: add transaction function to delete " Stefan Beller
2014-12-06 2:46 ` [PATCH 6/8] refs.c: use a reflog transaction when writing during expire Stefan Beller
2014-12-06 2:46 ` [PATCH 7/8] refs.c: rename log_ref_setup to create_reflog Stefan Beller
2014-12-06 2:46 ` [PATCH 8/8] refs.c: allow deleting refs with a broken sha1 Stefan Beller
2014-12-08 20:05 ` Stefan Beller [this message]
2014-12-08 21:54 ` [PATCH 0/8] Making reflog modifications part of the transactions API Jonathan Nieder
2014-12-12 16:17 ` Michael Haggerty
2014-12-12 20:51 ` Stefan Beller
2014-12-12 21:16 ` ronnie sahlberg
2014-12-14 23:17 ` Michael Haggerty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGZ79kb1yiSENO+uANdeOKtcSCZgZA3UXSdE2F5PBA49erh2Jw@mail.gmail.com \
--to=sbeller@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=mhagger@alum.mit.edu \
--cc=ronniesahlberg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).