From: Stefan Beller <sbeller@google.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [PATCH] vcs-svn/repo_tree.h: remove repo_init declaration
Date: Tue, 22 Aug 2017 15:24:19 -0700 [thread overview]
Message-ID: <CAGZ79kbMc+kVsc2-fBfOHVZvvABWnDpQfs-hqLCxb2FTTr8YCQ@mail.gmail.com> (raw)
In-Reply-To: <xmqqmv6r1c26.fsf@gitster.mtv.corp.google.com>
On Tue, Aug 22, 2017 at 3:18 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Stefan Beller <sbeller@google.com> writes:
>
>
>> The svn specific declaration of repo_init was not used since 723b7a2789
>> (vcs-svn: eliminate repo_tree structure, 2010-12-10).
>>
>> This was noticed when including repository.h via cache.h as that has the
>> same function with a different signature.
>>
>> Helped-by: Jonathan Nieder <jrnieder@gmail.com>
>> Signed-off-by: Stefan Beller <sbeller@google.com>
>> ---
>
> It looks to me that this is a reduced duplicate of what brian posted
> yesterday. The first two patches in the 6-patch series that you
> commented on, I think, covers what this change wants to achieve and
> probably a lot more. I've merged those two already to 'next' and
> was about to push the result out.
>
> Thanks.
>
Ok, thanks. I did not remember reviewing those.
(I just wanted to fix my odd compile error here,
and currently I build a series on top of jt/packmigrate
so I shot off a quick one liner)
Sorry for the noise.
next prev parent reply other threads:[~2017-08-22 22:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-22 21:35 [PATCH] vcs-svn/repo_tree.h: remove repo_init declaration Stefan Beller
2017-08-22 22:18 ` Junio C Hamano
2017-08-22 22:24 ` Stefan Beller [this message]
2017-08-22 22:54 ` Jonathan Nieder
2017-08-22 23:45 ` Jonathan Nieder
2017-08-23 1:10 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGZ79kbMc+kVsc2-fBfOHVZvvABWnDpQfs-hqLCxb2FTTr8YCQ@mail.gmail.com \
--to=sbeller@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).