git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Beller <sbeller@google.com>
To: Brandon Williams <bmwill@google.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [PATCH 3/3] push: add option to push only submodules
Date: Mon, 19 Dec 2016 10:56:14 -0800	[thread overview]
Message-ID: <CAGZ79kbc_o-B4nX8T1WN4z2PrpSHmrFBskeRA1rbdkzdnv2okw@mail.gmail.com> (raw)
In-Reply-To: <1482171933-180601-4-git-send-email-bmwill@google.com>

On Mon, Dec 19, 2016 at 10:25 AM, Brandon Williams <bmwill@google.com> wrote:
> Teach push the --recurse-submodules=only option.  This enables push to
> recursively push all unpushed submodules while leaving the superproject
> unpushed.
>
> This is a desirable feature in a scenario where updates to the
> superproject are handled automatically by some other means, perhaps a

e.g. Gerrit. (No need to be shy about our code review tool)

>
> code review tool.  In this scenario a developer could make a change
> which spans multiple submodules and then push their commits for code
> review.  Upon completion of the code review, their commits can be
> accepted and applied to their respective submodules while the code
> review tool can then automatically update the superproject to the most
> recent SHA1 of each submodule.  This would eliminate the merge conflicts
> in the superproject that could occur if multiple people are contributing
> to the same submodule.

Code and tests look good to me, I think the commit message
is good enough, but let's hear Junio on this one.

Thanks,
Stefan

  reply	other threads:[~2016-12-19 18:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-19 18:25 [PATCH 0/3] push only submodules Brandon Williams
2016-12-19 18:25 ` [PATCH 1/3] transport: refactor flag #defines to be more readable Brandon Williams
2016-12-19 18:25 ` [PATCH 2/3] submodules: add RECURSE_SUBMODULES_ONLY value Brandon Williams
2016-12-19 18:25 ` [PATCH 3/3] push: add option to push only submodules Brandon Williams
2016-12-19 18:56   ` Stefan Beller [this message]
2016-12-19 18:41 ` [PATCH 0/3] " Junio C Hamano
2016-12-20 19:25 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGZ79kbc_o-B4nX8T1WN4z2PrpSHmrFBskeRA1rbdkzdnv2okw@mail.gmail.com \
    --to=sbeller@google.com \
    --cc=bmwill@google.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).