From: Stefan Beller <sbeller@google.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: ronnie sahlberg <ronniesahlberg@gmail.com>,
Michael Haggerty <mhagger@alum.mit.edu>,
Jonathan Nieder <jrnieder@gmail.com>,
Junio C Hamano <gitster@pobox.com>,
Git List <git@vger.kernel.org>
Subject: Re: [PATCHv8 4/9] receive-pack.c: simplify execute_commands
Date: Tue, 30 Dec 2014 00:41:26 -0800 [thread overview]
Message-ID: <CAGZ79kbthoUbeHEGUv4QSGwAsbLjEPhFFLgGMi++3iPqU5bvyQ@mail.gmail.com> (raw)
In-Reply-To: <CAPig+cT9JVkDvUUsbx9HW8HpakCb9SkoQf3LJZc4h3TQTt2ZXQ@mail.gmail.com>
reply to all instead of reply to Eric only.
On Mon, Dec 29, 2014 at 10:11 PM, Eric Sunshine <sunshine@sunshineco.com> wrote:
> In v6, you considered this a fatal error in the atomic case, which
> caused the entire transaction to be rolled back. However, in this
> version, this error has no effect whatsoever on the atomic
> transaction, which is a rather significant behavioral departure. Which
> is correct? (This is a genuine question; not at all rhetorical.) If
> failing the entire transaction is the correct thing to do, then this
> is going to need some more work.
I don't know. in v6 I thought *any* error would stop and abort the atomic
commit. An atomic commit is either completely free of failures or it
doesn't work out.
However that warning doesn't seem to have any effect as of now
(apart from warning the user obviously), and is about the (highly
unlikely?) case of
a bug in git (or a provided helper script/hook?), I thought we can go
with it as well.
The transaction wen't through so all is fine. The thing the warning is
about is about
reachability checks for the shallow case, so I don't see why that
should fail the transaction.
next prev parent reply other threads:[~2014-12-30 8:41 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-30 2:36 [PATCHv8 0/9] atomic pushes Stefan Beller
2014-12-30 2:36 ` [PATCHv8 1/9] receive-pack.c: add documentation for atomic push support Stefan Beller
2014-12-30 7:08 ` Eric Sunshine
2014-12-30 8:33 ` Stefan Beller
2014-12-30 9:09 ` Eric Sunshine
2014-12-30 2:36 ` [PATCHv8 2/9] send-pack: rename ref_update_to_be_sent to check_to_send_update Stefan Beller
2014-12-30 2:36 ` [PATCHv8 3/9] send-pack.c: add --atomic command line argument Stefan Beller
2014-12-30 2:36 ` [PATCHv8 4/9] receive-pack.c: simplify execute_commands Stefan Beller
2014-12-30 6:11 ` Eric Sunshine
2014-12-30 8:41 ` Stefan Beller [this message]
2014-12-30 20:33 ` Stefan Beller
2014-12-30 21:15 ` Eric Sunshine
2014-12-30 7:46 ` Eric Sunshine
2014-12-30 8:42 ` Stefan Beller
2014-12-30 9:10 ` Eric Sunshine
2014-12-30 2:36 ` [PATCHv8 5/9] receive-pack.c: move transaction handling in a central place Stefan Beller
2014-12-30 8:36 ` Eric Sunshine
2014-12-30 18:45 ` Stefan Beller
2014-12-30 20:33 ` Eric Sunshine
2014-12-30 2:36 ` [PATCHv8 6/9] receive-pack.c: add execute_commands_atomic function Stefan Beller
2014-12-30 8:57 ` Eric Sunshine
2014-12-30 2:36 ` [PATCHv8 7/9] receive-pack.c: enable atomic push protocol support Stefan Beller
2014-12-30 2:36 ` [PATCHv8 8/9] push.c: add an --atomic argument Stefan Beller
2014-12-30 2:36 ` [PATCHv8 9/9] t5543-atomic-push.sh: add basic tests for atomic pushes Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGZ79kbthoUbeHEGUv4QSGwAsbLjEPhFFLgGMi++3iPqU5bvyQ@mail.gmail.com \
--to=sbeller@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=mhagger@alum.mit.edu \
--cc=ronniesahlberg@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).