From: Sverre Rabbelier <srabbelier@gmail.com>
To: BJ Hargrave <bj@bjhargrave.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] Support empty blob in fsck --lost-found
Date: Sun, 11 Sep 2011 18:21:31 +0200 [thread overview]
Message-ID: <CAGdFq_iLnCtXWJsiYLatzyi3bjz1drv1kmM54y8mMkNaU8b33A@mail.gmail.com> (raw)
In-Reply-To: <E6A02216-CA67-4B66-AA8F-6DDE8AF7DF3A@bjhargrave.com>
Heya,
On Sun, Sep 11, 2011 at 18:20, BJ Hargrave <bj@bjhargrave.com> wrote:
> You don't need to write anything to the 0-byte file. Just create it and
> close it and there are checks already that verify the fopen and fclose
> do not fail. So I don't think we are missing any error conditions here.
Works for me :).
--
Cheers,
Sverre Rabbelier
next prev parent reply other threads:[~2011-09-11 16:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-11 15:40 [PATCH] Support empty blob in fsck --lost-found BJ Hargrave
2011-09-11 16:03 ` Sverre Rabbelier
2011-09-11 16:20 ` BJ Hargrave
2011-09-11 16:21 ` Sverre Rabbelier [this message]
2011-09-11 20:43 ` Junio C Hamano
2011-09-11 21:43 ` BJ Hargrave
2011-09-12 1:10 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGdFq_iLnCtXWJsiYLatzyi3bjz1drv1kmM54y8mMkNaU8b33A@mail.gmail.com \
--to=srabbelier@gmail.com \
--cc=bj@bjhargrave.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).