From: Sverre Rabbelier <srabbelier@gmail.com>
To: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Cc: Junio C Hamano <gitster@pobox.com>,
GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH 2/2] obstack.c: Fix some sparse warnings
Date: Sun, 11 Sep 2011 23:56:43 +0200 [thread overview]
Message-ID: <CAGdFq_ifU2WWbCpRY_EFY=_hwwtFs0eqMhJ7sRoUhrivABFoFw@mail.gmail.com> (raw)
In-Reply-To: <4E6D0B7D.9070602@ramsay1.demon.co.uk>
Heya,
On Sun, Sep 11, 2011 at 21:26, Ramsay Jones <ramsay@ramsay1.demon.co.uk> wrote:
> compat/obstack.c:399:1: error: symbol 'print_and_abort' redeclared with \
> different type (originally declared at compat/obstack.c:95) \
> - different modifiers
> @@ -395,7 +395,6 @@ _obstack_memory_used (struct obstack *h)
> # endif
>
> static void
> -__attribute__ ((noreturn))
> print_and_abort (void)
> {
> /* Don't change any of these strings. Yes, it would be possible to add
Wouldn't the better solution be to add noreturn to the declaration at
compat/obstack.c:95?
--
Cheers,
Sverre Rabbelier
next prev parent reply other threads:[~2011-09-11 21:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-11 19:26 [PATCH 2/2] obstack.c: Fix some sparse warnings Ramsay Jones
2011-09-11 21:56 ` Sverre Rabbelier [this message]
2011-09-13 23:18 ` Ramsay Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGdFq_ifU2WWbCpRY_EFY=_hwwtFs0eqMhJ7sRoUhrivABFoFw@mail.gmail.com' \
--to=srabbelier@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ramsay@ramsay1.demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).