From: Sverre Rabbelier <srabbelier@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Git List <git@vger.kernel.org>,
Felipe Contreras <felipe.contreras@gmail.com>,
Junio C Hamano <gitster@pobox.com>,
Thomas Rast <trast@student.ethz.ch>
Subject: Re: [PATCH 2/2] transport-helper: mention helper name when it dies
Date: Wed, 10 Apr 2013 14:23:56 -0700 [thread overview]
Message-ID: <CAGdFq_j5vB+OJAkuk-EMLjyrbiY7QrBiwWPraPA7SWTtuUqgZA@mail.gmail.com> (raw)
In-Reply-To: <20130410211603.GB3256@sigill.intra.peff.net>
On Wed, Apr 10, 2013 at 2:16 PM, Jeff King <peff@peff.net> wrote:
> When we try to read from a remote-helper and get EOF or an
> error, we print a message indicating that the helper died.
> However, users may not know that a remote helper was in use
> (e.g., when using git-over-http), or even what a remote
> helper is.
>
> Let's print the name of the helper (e.g., "git-remote-https");
> this makes it more obvious what the program is for, and
> provides a useful token for reporting bugs or searching for
> more information (e.g., in manpages).
>
> Signed-off-by: Jeff King <peff@peff.net>
Better than nothing:
Acked-by: Sverre Rabbelier <srabbelier@gmail.com>
--
Cheers,
Sverre Rabbelier
next prev parent reply other threads:[~2013-04-10 21:24 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-08 14:40 [PATCH v4] transport-helper: report errors properly Felipe Contreras
2013-04-08 18:20 ` Sverre Rabbelier
2013-04-08 19:30 ` Jeff King
2013-04-08 19:28 ` Jeff King
2013-04-09 21:38 ` Thomas Rast
2013-04-09 21:50 ` Jeff King
2013-04-10 21:13 ` [PATCH v5 0/2] reporting transport helper errors Jeff King
2013-04-10 21:15 ` [PATCH 1/2] transport-helper: report errors properly Jeff King
2013-04-10 21:22 ` Sverre Rabbelier
2013-04-10 21:46 ` Eric Sunshine
2013-04-11 13:22 ` Felipe Contreras
2013-04-11 16:18 ` Jeff King
2013-04-11 16:49 ` Felipe Contreras
2013-04-11 16:59 ` Jeff King
2013-04-11 17:57 ` Felipe Contreras
2013-04-11 18:49 ` Junio C Hamano
2013-04-11 21:35 ` Felipe Contreras
2013-04-11 18:44 ` Junio C Hamano
2013-04-11 21:21 ` Felipe Contreras
2013-04-11 23:05 ` Junio C Hamano
2013-04-13 5:42 ` Felipe Contreras
2013-04-13 6:00 ` Jeff King
2013-04-13 6:43 ` Felipe Contreras
2013-04-14 5:23 ` Junio C Hamano
2013-04-14 15:54 ` Felipe Contreras
2013-04-10 21:16 ` [PATCH 2/2] transport-helper: mention helper name when it dies Jeff King
2013-04-10 21:23 ` Sverre Rabbelier [this message]
2013-04-10 21:28 ` Jeff King
2013-04-10 21:35 ` Sverre Rabbelier
2013-04-10 23:13 ` [PATCH v4] transport-helper: report errors properly rh
2013-04-11 3:39 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGdFq_j5vB+OJAkuk-EMLjyrbiY7QrBiwWPraPA7SWTtuUqgZA@mail.gmail.com \
--to=srabbelier@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).