From: Sverre Rabbelier <srabbelier@gmail.com>
To: Vitor Antunes <vitor.hda@gmail.com>
Cc: Dmitry Ivankov <divanorama@gmail.com>,
Jonathan Nieder <jrnieder@gmail.com>,
git@vger.kernel.org, David Barr <davidbarr@google.com>
Subject: Re: [PATCH v0] fast-import: Add drop command
Date: Wed, 9 Nov 2011 01:27:03 +0100 [thread overview]
Message-ID: <CAGdFq_jPfSFidb59m-5Tsyusw3yQFRnxU9nqBVosVPuzbt86GA@mail.gmail.com> (raw)
In-Reply-To: <CAOpHH-X3bgJpRpiJMy-iDDpaFbUy8yZK+GFEwVB2vGHd-GpUiw@mail.gmail.com>
Heya,
On Wed, Nov 9, 2011 at 01:24, Vitor Antunes <vitor.hda@gmail.com> wrote:
> On Thu, Oct 27, 2011 at 3:36 PM, Sverre Rabbelier <srabbelier@gmail.com> wrote:
>> Ok, so the problem is that fast-import notices that a tree that was
>> written out as part of a checkpoint is later removed and doesn't like
>> that? Shouldn't we just teach the check about trees deleted by the
>> drop command?
>
> That was exactly my intention when I used release_tree_entry(). But I
> guess I'm doing it wrong, because without the delete_ref() part this
> does not work (just noticed there's a missing semicolon there...
> sorry). Any advices/guidance, please? :)
ENODATA. What do you mean with "does not work"? Can you run it through
gdb and see what's going on?
--
Cheers,
Sverre Rabbelier
next prev parent reply other threads:[~2011-11-09 0:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-24 15:27 [PATCH v0] fast-import: Add drop command Vitor Antunes
2011-09-24 15:27 ` Vitor Antunes
2011-09-24 19:37 ` Jonathan Nieder
2011-09-24 21:19 ` Dmitry Ivankov
2011-09-27 8:57 ` Vitor Antunes
2011-10-24 16:37 ` Vitor Antunes
2011-10-24 18:01 ` Sverre Rabbelier
2011-10-25 9:56 ` Vitor Antunes
2011-10-27 11:06 ` Sverre Rabbelier
2011-10-27 11:22 ` Vitor Antunes
2011-10-27 14:36 ` Sverre Rabbelier
2011-11-09 0:24 ` Vitor Antunes
2011-11-09 0:27 ` Sverre Rabbelier [this message]
2011-11-09 11:29 ` Vitor Antunes
2011-09-24 21:35 ` Vitor Antunes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGdFq_jPfSFidb59m-5Tsyusw3yQFRnxU9nqBVosVPuzbt86GA@mail.gmail.com \
--to=srabbelier@gmail.com \
--cc=davidbarr@google.com \
--cc=divanorama@gmail.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=vitor.hda@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).