From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sverre Rabbelier Subject: Re: [PATCH 3/5] setup_revisions: remember whether a ref was positive or not Date: Tue, 9 Aug 2011 00:28:56 +0200 Message-ID: References: <1311517282-24831-1-git-send-email-srabbelier@gmail.com> <1311517282-24831-4-git-send-email-srabbelier@gmail.com> <7vy5znscst.fsf@alter.siamese.dyndns.org> <7vr55fs1z0.fsf@alter.siamese.dyndns.org> <7vy5zabbz7.fsf@alter.siamese.dyndns.org> <7vfwlbztfg.fsf@alter.siamese.dyndns.org> <7vpqkfv8x1.fsf@alter.siamese.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: Johannes Schindelin , Jonathan Nieder , Jeff King , Git List , Daniel Barkalow , Ramkumar Ramachandra , Dmitry Ivankov To: Junio C Hamano X-From: git-owner@vger.kernel.org Tue Aug 09 00:29:46 2011 Return-path: Envelope-to: gcvg-git-2@lo.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QqYKQ-0008Ua-6i for gcvg-git-2@lo.gmane.org; Tue, 09 Aug 2011 00:29:46 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752279Ab1HHW3h (ORCPT ); Mon, 8 Aug 2011 18:29:37 -0400 Received: from mail-pz0-f42.google.com ([209.85.210.42]:46446 "EHLO mail-pz0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751464Ab1HHW3h (ORCPT ); Mon, 8 Aug 2011 18:29:37 -0400 Received: by pzk37 with SMTP id 37so8994885pzk.1 for ; Mon, 08 Aug 2011 15:29:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=84arNm3+Es9I2e36rpqIZHr+XJUkQHfx6RlfzxIje5s=; b=dO5SmGlXUHFUdnC1LptXaKRa6+feNpME+xTveFhhM17AF/8AvsnY68OaUFQUR2WV7n XAspgF3jKfkcd21sR4fSNe/ordm0mX8ZALubHcgP0yzh3A0UapUOd3E5RezDwKXpdAj4 pclVCeJ7sdUsZ6djTOWB2nA41ZrOrSiEawqcw= Received: by 10.143.13.10 with SMTP id q10mr6519593wfi.64.1312842576061; Mon, 08 Aug 2011 15:29:36 -0700 (PDT) Received: by 10.68.63.102 with HTTP; Mon, 8 Aug 2011 15:28:56 -0700 (PDT) In-Reply-To: <7vpqkfv8x1.fsf@alter.siamese.dyndns.org> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Heya, On Tue, Aug 9, 2011 at 00:24, Junio C Hamano wrote: > Hmm, which means you have a way to say "explicitly affirmative" vs "no > information", but no way to say "explicitly negative", for example, and > the worse part is that it is unclear if the approach the patch takes is > extensible enough to allow that in the future. That is the kind of "myopic > hack" attitude I did not particularly like in this patch. Do we have a way to say explicitly negative on the commandline? Is there a way to say "I don't want you to decorate this commit as anything at all"? > "The next person who needs more generic framework can rip out what this > patch does and the work required is the same amount" is not a convincing > argument---it would mean you are burdening that other person with an extra > work to _redo_ what this series does properly, and it is not likely to be > of help for that person after your interest in this codepath has long > waned. Be fair. How is "2 files changed, 8 insertions(+), 6 deletions(-)" going to make it any harder at all for someone who is going to be doing that huge patch series you described earlier? >> Don't we already store that in the name field? > > Please remind yourself why then it is not sufficient for your patch to > read from the name field please? Sure, we could do it. But it would be duplicating all the effort already being done in rev-parse! > After all, wasn't the issue that "master^0..master" yields an empty set > but you somehow wanted to know that the RHS of that dotdot was given as a > positive ref? The issue was that if I push "master" to origin but I already pushed a "next" which points at the same commit nothing happens because git-fast-export doesn't know to emit the "reset master :13878" line. -- Cheers, Sverre Rabbelier