From: Bryan Turner <bturner@atlassian.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: newren@gmail.com, "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Git Users" <git@vger.kernel.org>
Subject: Re: Forcing GC to always fail
Date: Wed, 28 Nov 2018 18:51:28 -0800 [thread overview]
Message-ID: <CAGyf7-FVxHak7zN7jpEe4xu7mWn4T7H4szvsLqNGM1UH_0_5eg@mail.gmail.com> (raw)
In-Reply-To: <xmqqtvk0r87v.fsf@gitster-ct.c.googlers.com>
On Wed, Nov 28, 2018 at 5:19 PM Junio C Hamano <gitster@pobox.com> wrote:
>
> > Another issue with the canned steps for "git gc" is that it means it
> > can't be used to do specific types of cleanup on a different schedule
> > from others. For example, we use "git pack-refs" directly to
> > frequently pack the refs in our repositories, separate from "git
> > repack" + "git prune" for repacking objects. That allows us to keep
> > our refs packed better without incurring the full overhead of
> > constantly building new packs.
>
> I am not sure if the above is an example of things that are good.
> We keep individual "pack-refs" and "rev-list | pack-objects"
> available exactly to give finer grained control to repository
> owners, and "gc" is meant to be one-size-fits-all easy to run
> by end users. Adding options to "git gc --no-reflog --pack-refs"
> to complicate it sounds somewhat backwards.
I think we're in agreement there. I was citing the fact that GC isn't
good for targeted maintenance as a reason why we use "pack-refs"
directly, which sounds like what you're saying as well. I don't think
that inflating GC with options to skip specific steps is a good idea,
but that does mean that, for those targeted operations, we need to use
the lower-level commands directly, rather than GC.
Bryan
prev parent reply other threads:[~2018-11-29 2:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-27 21:08 Forcing GC to always fail Bryan Turner
2018-11-27 23:47 ` Ævar Arnfjörð Bjarmason
2018-11-28 0:00 ` Bryan Turner
2018-11-28 0:11 ` Ævar Arnfjörð Bjarmason
2018-11-28 1:55 ` Elijah Newren
2018-11-28 2:26 ` Bryan Turner
2018-11-29 1:19 ` Junio C Hamano
2018-11-29 2:51 ` Bryan Turner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGyf7-FVxHak7zN7jpEe4xu7mWn4T7H4szvsLqNGM1UH_0_5eg@mail.gmail.com \
--to=bturner@atlassian.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=newren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).