From: Jon Seymour <jon.seymour@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Jens.Lehmann@web.de, phil.hord@gmail.com,
ramsay@ramsay1.demon.co.uk, j6t@kdbg.org
Subject: Re: [PATCH v8 3/4] submodule: fix sync handling of some relative superproject origin URLs
Date: Mon, 4 Jun 2012 09:52:05 +1000 [thread overview]
Message-ID: <CAH3AnrrUNq9q54dxQidAKD5oAmTSs2hJnWR09jWxmZFYgnfKFw@mail.gmail.com> (raw)
In-Reply-To: <7v1ulwxd0o.fsf@alter.siamese.dyndns.org>
On Mon, Jun 4, 2012 at 8:10 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Jon Seymour <jon.seymour@gmail.com> writes:
>
> Style: please align case/esac and the labels on case arms (see how
> two existing nested case statements in this function are written).
Thanks.
> Didn't we add some workaround for implementations of sed that do not
> match and replace a possibly empty pattern? Am I seeing the same
> breakage as c5bc42b (Avoid bug in Solaris xpg4/sed as used in
> submodule, 2012-04-09) addressed with this patch?
Have modified accordingly. It may not have mattered *much* in this
case since I think
normalisation during git submodule add would have ensured at least one matching
character, but then I don't pretend to understand the nature of the
Solaris issue and
that would in any case, not protect against a manual .gitmodules edit.
I'll re-roll in a day or so after Jens (and/or others) have had a
chance to comment.
jon.
next prev parent reply other threads:[~2012-06-03 23:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-03 9:46 [PATCH v8 0/4] submodule: improve support for relative superproject origin URLs Jon Seymour
2012-06-03 9:46 ` [PATCH v8 1/4] submodule: additional regression tests for relative URLs Jon Seymour
2012-06-03 9:46 ` [PATCH v8 2/4] submodule: document failure to handle relative superproject origin URLs Jon Seymour
2012-06-03 9:46 ` [PATCH v8 3/4] submodule: fix sync handling of some " Jon Seymour
2012-06-03 22:10 ` Junio C Hamano
2012-06-03 23:52 ` Jon Seymour [this message]
2012-06-05 21:18 ` Jens Lehmann
2012-06-05 22:49 ` Junio C Hamano
2012-06-06 11:09 ` Jon Seymour
2012-06-03 9:46 ` [PATCH v8 4/4] submodule: fix handling of superproject origin URLs like foo, ./foo and ./foo/bar Jon Seymour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAH3AnrrUNq9q54dxQidAKD5oAmTSs2hJnWR09jWxmZFYgnfKFw@mail.gmail.com \
--to=jon.seymour@gmail.com \
--cc=Jens.Lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=phil.hord@gmail.com \
--cc=ramsay@ramsay1.demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).