From: Matus Faro <matusfaro@gmail.com>
To: git@vger.kernel.org
Subject: Distributed code review discussion
Date: Sat, 10 Jan 2015 13:05:35 -0500 [thread overview]
Message-ID: <CAH5CKOqSc2qLZwhCrafYkXMvLmRxKeA_7OO+WzM2FQwKS9F3cQ@mail.gmail.com> (raw)
Are there any plans for supporting merge requests and code reviews
natively in git?
What I mean is a distributed code review system where a merge request
along with review comments would be stored within the git repository
and allowed to be pushed and pulled between repository clones. This
would allow users to retain the code review history without relying on
centralized or proprietary third party solutions.
I am debating on creating a plugin for the current git suite starting
with a bash script as a proof of concept and eventually creating a GUI
via Tcl/Tk for best cross-platform support. The idea is to store the
code review metadata as empty commits within a branch. This is for a
number of reasons:
- Ensure backwards compatibility with all current git clients. Classic
git push, pull, merge commands will be able to move the code review
metadata around.
- Easy migration on and off of the distributed code review system. No
leftover metadata stored within the user's repository besides human
readable commits.
- If desired, empty commits can be easily squashed after merge or
summarized into a single commit to retain history.
- Commits can be created outside of the code review plugin.
Example commits:
"## Open refs/heads/distributed-review -> refs/heads/master --
Distributed code review feature"
"## Comment 71a3f9 src/review.c:412 -- Did you even compile this?"
"## Close 71a3f9 -- This feature is horrible, closing..."
Questions:
- Are you interested in adding this sort of functionality to git? I
would be very interested in contributing instead of working alone.
- Am I crazy? Do you see an interest from the community in distributed
code reviews?
- Any other criticism?
Thank you,
Matus Faro
next reply other threads:[~2015-01-10 18:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-10 18:05 Matus Faro [this message]
2015-01-10 18:34 ` Distributed code review discussion Junio C Hamano
2015-01-10 18:54 ` W. Trevor King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAH5CKOqSc2qLZwhCrafYkXMvLmRxKeA_7OO+WzM2FQwKS9F3cQ@mail.gmail.com \
--to=matusfaro@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).