git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Tapsell <johnflux@gmail.com>
To: Git List <git@vger.kernel.org>
Subject: Re: git log -p unexpected behaviour
Date: Wed, 1 May 2013 08:23:32 +0100	[thread overview]
Message-ID: <CAHQ6N+rs1miLLUWsGvu5W-nUxU9NK30JEo8gcjXpdGLLXvqK7g@mail.gmail.com> (raw)
In-Reply-To: <7vvc73bvp9.fsf@alter.siamese.dyndns.org>

On 30 April 2013 21:38, Junio C Hamano <gitster@pobox.com> wrote:
> John Tapsell <johnflux@gmail.com> writes:
>
>> On 30 April 2013 20:44, Junio C Hamano <gitster@pobox.com> wrote:
>>> John Tapsell <johnflux@gmail.com> writes:
>>>
>>>> Is there no way to fix --cc to work even in the edge cases?
>>>
>>> Can you clarify what you mean by "fix" and "edge cases"?
>>
>> My understanding is that even with -cc there will be changes that
>> won't be seen - and hence why --cc could be even more of a "security
>> risk", no?
>
> Combined diff is a way to show a tricky conflict resolved in a
> tricky way, so that the tricky-ness of the resolution can be
> examined.  A trivial resolution that takes one side is not shown
> because it is not usually interesting.

I don't really understand your point sorry.  In this trivial
resolution case, you would still just see the commit that added the
code in a later commit.  No?

There couldn't be a case where you add or change a line of code, but
not see it with --cc ?

> This design choice of course
> have to trust people involved in the project do not pull from
> untrustworthy sources.
>
> You would need "log -p -m" (without any pathspec) for the kind of
> "security" you are talking about.  Note that "-p -m --first-parent"
> is not necessarily enough.

This results in seeing the same change more than once though, right?

  reply	other threads:[~2013-05-01  7:23 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-11 10:36 git log -p unexpected behaviour - security risk? John Tapsell
2013-04-11 15:19 ` Tay Ray Chuan
2013-04-20 14:00 ` Simon Ruderich
2013-04-21  7:26   ` Junio C Hamano
2013-04-21  8:56     ` John Tapsell
2013-04-21 10:21       ` Jonathan Nieder
2013-04-21 13:46         ` John Tapsell
2013-04-21 15:56           ` Thomas Rast
2013-04-21 16:09           ` Jonathan Nieder
2013-04-21 18:42             ` Junio C Hamano
2013-04-30 10:09               ` John Szakmeister
2013-04-30 16:37                 ` Junio C Hamano
2013-04-30 16:47                   ` John Szakmeister
2013-04-30 17:05                   ` Matthieu Moy
2013-04-30 17:58                     ` John Szakmeister
2013-04-30 19:31                       ` John Tapsell
2013-04-30 19:44                         ` git log -p unexpected behaviour Junio C Hamano
2013-04-30 20:12                           ` John Tapsell
2013-04-30 20:38                             ` Junio C Hamano
2013-05-01  7:23                               ` John Tapsell [this message]
2013-04-30 11:48             ` git log -p unexpected behaviour - security risk? shawn wilson
2013-04-21 18:25         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHQ6N+rs1miLLUWsGvu5W-nUxU9NK30JEo8gcjXpdGLLXvqK7g@mail.gmail.com \
    --to=johnflux@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).