From: 乙酸鋰 <ch3cooli@gmail.com>
To: git@vger.kernel.org
Subject: Do not add an empty value from config credential.helper
Date: Sat, 10 Nov 2012 23:08:04 +0800 [thread overview]
Message-ID: <CAHtLG6Snuv4x+xvqJRmEo8b8TJRPqBP46kanSsfvhgDWfDbuOg@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 382 bytes --]
Below is current git message when a local config credential.helper has
an empty value. Please skip an empty value.
$ git push --force origin master
git: 'credential-' is not a git command. See 'git --help'.
Did you mean this?
credential
Total 0 (delta 0), reused 0 (delta 0)
To https://user@github.com/user/myrepo.git
+ d23aa6a...3405990 master -> master (forced update)
[-- Attachment #2: 0001-credential-do-not-recognize-a-credential-helper-if-c.patch --]
[-- Type: application/octet-stream, Size: 781 bytes --]
From 0b3ec07ed893a0d595cf48c55d884ff844f1108f Mon Sep 17 00:00:00 2001
From: Sup Yut Sum <ch3cooli@gmail.com>
Date: Sat, 10 Nov 2012 22:24:30 +0800
Subject: [PATCH] credential: do not recognize a credential helper if config
value is empty
Signed-off-by: Sup Yut Sum <ch3cooli@gmail.com>
---
credential.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/credential.c b/credential.c
index e54753c..1489e7a 100644
--- a/credential.c
+++ b/credential.c
@@ -64,7 +64,7 @@ static int credential_config_callback(const char *var, const char *value,
key = dot + 1;
}
- if (!strcmp(key, "helper"))
+ if (!strcmp(key, "helper") && *value)
string_list_append(&c->helpers, value);
else if (!strcmp(key, "username")) {
if (!c->username)
--
1.8.0.msysgit.0
reply other threads:[~2012-11-10 15:13 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHtLG6Snuv4x+xvqJRmEo8b8TJRPqBP46kanSsfvhgDWfDbuOg@mail.gmail.com \
--to=ch3cooli@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).