From: Stan Pitucha <stan.pitucha@envato.com>
To: git@vger.kernel.org
Subject: Bad experience with gpg signing failures
Date: Fri, 24 Apr 2020 10:23:02 +1000 [thread overview]
Message-ID: <CAJ2_uEOk8xoLvK8B8PYc0_=kA8W_LqKwGyhKghemQDdRzA2nFA@mail.gmail.com> (raw)
Hi all,
There are two issues I keep running into with gpg signing usability:
1. When gpg fails to sign the commit, the error message is not
forwarded. That means you always get "gpg failed to sign the data"
when the actual gpg error is for example "gpg: skipped ...: Unusable
secret key". This makes the errors hard to deal with, because you
don't know which command actually failed without GIT_TRACE. That's
especially bad in case of transient errors.
2. When gpg fails to sign the commit, it's not reported where it's
available. I found that it's possible to recover it from
COMMIT_EDITMSG from man pages, but it would be great if "gpg failed to
sign the data" message was followed with "your message draft was saved
to .git/COMMIT_EDITMSG" to make it more discoverable / not require
reading full manual to find out about it.
--
Stan Pitucha
Site Reliability Engineer at Envato
http://envato.com
The email and any attachments are confidential and may contain
information that is exempt from disclosure by law and subject to
copyright. If you have received this message in error please let me
know and delete it.
reply other threads:[~2020-04-24 0:23 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ2_uEOk8xoLvK8B8PYc0_=kA8W_LqKwGyhKghemQDdRzA2nFA@mail.gmail.com' \
--to=stan.pitucha@envato.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).