git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Allen Hubbe <allenbh@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Eric Sunshine <sunshine@sunshineco.com>
Subject: Re: [PATCH v5 1/1] send-email: Add sendmail email aliases format
Date: Mon, 25 May 2015 08:47:32 -0400	[thread overview]
Message-ID: <CAJ80sas_D-6z4MvuFvvjoX7U_bM6b3brCo4rvYFCUfTmKS=6bA@mail.gmail.com> (raw)
In-Reply-To: <CAJ80savVjb3_iKhNWPjQNK72DL7eq5YkbjWWG-1Gkx5+LOjzeg@mail.gmail.com>

On Sat, May 23, 2015 at 6:24 PM, Allen Hubbe <allenbh@gmail.com> wrote:
> On Sat, May 23, 2015 at 2:07 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> Junio C Hamano <gitster@pobox.com> writes:
>>
>>> A small thing I noticed in the test (and this patch is not adding a
>>> new "breakage"---there are a few existing instances) is the use of
>>> "~/"; it should be spelled "$HOME/" instead for portability (not in
>>> POSIX, even though bash, dash and ksh all seem to understand it).
>>
>> Well, I was wrong. Tilde expansion is in POSIX.
>>
>> Nevertheless, I'd prefer if we avoided it.
>
> Alright, $HOME it will be.

Looking closer at this and the other test cases, they are inconsistent
about using ".mailrc", "~/.mailrc", and "$(pwd)/.mailrc".  This would
add another one, "$HOME/.mailrc".

How do you feel about using just ".mailrc", and "$(pwd)/.mailrc" when
an absolute path is needed in gitconfig?

  reply	other threads:[~2015-05-25 12:47 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-23 13:21 [PATCH v5 1/1] send-email: Add sendmail email aliases format Allen Hubbe
2015-05-23 17:45 ` Junio C Hamano
2015-05-23 18:00   ` Junio C Hamano
2015-05-23 23:01     ` Allen Hubbe
2015-05-23 18:07   ` Junio C Hamano
2015-05-23 22:24     ` Allen Hubbe
2015-05-25 12:47       ` Allen Hubbe [this message]
2015-05-25 16:32         ` Junio C Hamano
2015-05-25 21:12           ` Junio C Hamano
2015-05-25 21:35             ` Junio C Hamano
2015-05-26  1:51               ` Allen Hubbe
2015-05-26  1:58                 ` Junio C Hamano
2015-05-26  2:16                   ` Allen Hubbe
2015-05-26  2:55                     ` Junio C Hamano
2015-05-26  3:34                       ` Junio C Hamano
2015-05-26 18:47   ` Eric Sunshine
2015-05-26 19:10 ` Eric Sunshine
2015-05-26 19:41   ` Allen Hubbe
2015-05-26 20:53     ` Eric Sunshine
2015-05-26 21:04       ` Allen Hubbe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJ80sas_D-6z4MvuFvvjoX7U_bM6b3brCo4rvYFCUfTmKS=6bA@mail.gmail.com' \
    --to=allenbh@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).