From: David Aguilar <davvid@gmail.com>
To: Sebastian Schuberth <sschuberth@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Tim Henigan <tim.henigan@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH 2/5] difftool: Eliminate global variables
Date: Sun, 22 Jul 2012 23:44:07 -0700 [thread overview]
Message-ID: <CAJDDKr77d0vot30txya7Z0QpOj2xgV4-0ZhOuyXiJbG2OSUNQQ@mail.gmail.com> (raw)
In-Reply-To: <CAHGBnuM9LgeLiOoFfny8NbF547okjQBLDXfzrbTj6vt+d=M4Eg@mail.gmail.com>
On Sun, Jul 22, 2012 at 11:30 PM, Sebastian Schuberth
<sschuberth@gmail.com> wrote:
> On Mon, Jul 23, 2012 at 8:21 AM, David Aguilar <davvid@gmail.com> wrote:
>
>>> Funny, I just have prepared a patch along the same lines so that one can
>>> call git-difftool -h and --tool-help also outside a repository, see below.
>>> Does you patch offer the same? If so, I'll drop mine.
>>
>> It *should*. I did not consider this case but that is indeed the
>> desired behavior.
>>
>> What my patch did not offer was a test to ensure this behavior...
>
> Well, I'm not asking for a test. From my side, I'd be happy if you
> could just try it and confirm that it works, as I currently cannot
> easily apply your patch.
Heheh.. I was hoping you could provide a test ;-)
I just tried it now. They work outside of a repository.
--
David
next prev parent reply other threads:[~2012-07-23 6:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-23 3:42 [PATCH 1/5] difftool: Simplify print_tool_help() David Aguilar
2012-07-23 3:42 ` [PATCH 2/5] difftool: Eliminate global variables David Aguilar
2012-07-23 6:13 ` Sebastian Schuberth
2012-07-23 6:21 ` David Aguilar
2012-07-23 6:30 ` Sebastian Schuberth
2012-07-23 6:44 ` David Aguilar [this message]
2012-07-23 6:54 ` Sebastian Schuberth
2012-07-23 3:42 ` [PATCH 3/5] difftool: Move option values into a hash David Aguilar
2012-07-23 3:49 ` David Aguilar
2012-07-23 3:42 ` [PATCH 5/5] difftool: Use symlinks when diffing against the worktree David Aguilar
2012-07-24 12:43 ` [PATCH 1/5] difftool: Simplify print_tool_help() Tim Henigan
2012-07-25 1:52 ` David Aguilar
2012-07-25 2:18 ` David Aguilar
2012-07-25 2:40 ` Junio C Hamano
2012-07-25 3:00 ` David Aguilar
-- strict thread matches above, loose matches on Subject: below --
2012-07-23 3:57 [PATCH v2 0/5] difftool: Use symlinks in dir-diff mode David Aguilar
2012-07-23 3:57 ` [PATCH v2 1/5] difftool: Simplify print_tool_help() David Aguilar
2012-07-23 3:57 ` [PATCH 2/5] difftool: Eliminate global variables David Aguilar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJDDKr77d0vot30txya7Z0QpOj2xgV4-0ZhOuyXiJbG2OSUNQQ@mail.gmail.com \
--to=davvid@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sschuberth@gmail.com \
--cc=tim.henigan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).