From: David Aguilar <davvid@gmail.com>
To: Jiang Xin <worldhello.net@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Git List <git@vger.kernel.org>,
avarab@gmail.com
Subject: Re: [PATCH v2] Maintaince script for l10n files and commits
Date: Thu, 8 Mar 2012 22:20:51 -0800 [thread overview]
Message-ID: <CAJDDKr7A1LN_r5v0yiacpEHTtEqQG2Hf=YZ6GbtsOHLadozDKA@mail.gmail.com> (raw)
In-Reply-To: <1331273307-64598-1-git-send-email-worldhello.net@gmail.com>
On Thu, Mar 8, 2012 at 10:08 PM, Jiang Xin <worldhello.net@gmail.com> wrote:
> diff --git a/po/po-helper.sh b/po/po-helper.sh
> new file mode 100755
> index 0000000..166ebb7
> --- /dev/null
> +++ b/po/po-helper.sh
> @@ -0,0 +1,387 @@
> +#!/bin/sh
> +#
> +# Copyright (c) 2012 Jiang Xin
> +
> +GIT=git
I think it's customary to just write `git` in shell scripts. It looks
nicer then seeing $GIT everywhere, IMO. I guess this could be helpful
in the future but I don't see GIT being reassigned anywhere.
Cheers,
--
David
next prev parent reply other threads:[~2012-03-09 6:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-07 18:47 [PATCH] Maintaince script for l10n files and commits Jiang Xin
2012-03-07 19:17 ` Junio C Hamano
2012-03-08 16:05 ` Jiang Xin
2012-03-08 20:41 ` Junio C Hamano
2012-03-09 0:57 ` Jiang Xin
2012-03-09 6:08 ` [PATCH v2] " Jiang Xin
2012-03-09 6:20 ` David Aguilar [this message]
2012-03-09 6:31 ` Jiang Xin
2012-03-10 0:40 ` Junio C Hamano
2012-03-10 9:17 ` [PATCH v3] " Jiang Xin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJDDKr7A1LN_r5v0yiacpEHTtEqQG2Hf=YZ6GbtsOHLadozDKA@mail.gmail.com' \
--to=davvid@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=worldhello.net@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).