From: David Aguilar <davvid@gmail.com>
To: Tim McCormack <cortex@brainonfire.net>
Cc: git@vger.kernel.org
Subject: Re: gitk does not reload tag messages
Date: Thu, 6 Sep 2012 20:08:26 -0700 [thread overview]
Message-ID: <CAJDDKr7AJ4Mrw8_wsB9WSqPT8sBca8FmBGHoq2Ay_ivLyUyAGg@mail.gmail.com> (raw)
In-Reply-To: <MTAwMDAxMC50aW1tYw.1346955478@quikprotect>
On Thu, Sep 6, 2012 at 11:17 AM, Tim McCormack <cortex@brainonfire.net> wrote:
> If a tag that gitk knows about is deleted and recreated with a
> different message, gitk still shows the old message after any
> combination of refresh, reload, and reread refs.
>
> git-gui version 0.13.0.8.g8f85
>
> Reproduce:
> 1. git tag -a test -m "foo" HEAD
> 2. Open gitk, see that correct message ("foo") is present for tag "test"
> 3. git tag -d test
> 4. Reload/refresh gitk [optional, it won't make a difference]
> 5. git tag -a test -m "bar" HEAD
> 6. Reload/refresh gitk
> 7. See that the message on tag "test" is still "foo"
> 8. $ git show test # shows correct message "bar"
>
> Apologies if this is an old version or a known bug; I could not find an
> issue tracker to search, although I did check the gmane archives.
Tags in git are meant to be immutable. You can delete them, but you shouldn't.
That's not really how they are intended to be used.
gitk avoids re-reading that information because the normal,
typical use case is that the tag messages do not change.
It would probably be a performance regression to "fix" this.
In which case, IMO it's not a bug.
--
David
next prev parent reply other threads:[~2012-09-07 3:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-06 18:17 gitk does not reload tag messages Tim McCormack
2012-09-07 3:08 ` David Aguilar [this message]
2012-09-07 5:18 ` Junio C Hamano
2012-09-08 19:03 ` [PATCH] gitk: Teach "Reread references" to reload tags David Aguilar
2012-09-08 19:53 ` [PATCH] gitk: Rename 'tagcontents' to 'cached_tagcontent' David Aguilar
2012-09-09 5:11 ` Junio C Hamano
2012-09-12 9:25 ` Junio C Hamano
2012-09-12 12:37 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJDDKr7AJ4Mrw8_wsB9WSqPT8sBca8FmBGHoq2Ay_ivLyUyAGg@mail.gmail.com \
--to=davvid@gmail.com \
--cc=cortex@brainonfire.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).