From: Pavan Kumar Sunkara <pavan.sss1991@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Git List" <git@vger.kernel.org>,
"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
"Jakub Narębski" <jnareb@gmail.com>
Subject: Re: [PATCH] gitweb: Added syntax highlight support for golang
Date: Sat, 8 Feb 2014 04:40:59 +0530 [thread overview]
Message-ID: <CAK9CXBWiaORDJaTam=X02UiBCsF2m_kW33_DqbQSLfoY1JphiQ@mail.gmail.com> (raw)
In-Reply-To: <xmqqa9e2ttln.fsf@gitster.dls.corp.google.com>
Yeah. I agree with you.
I am currently looking into allowing users to customize the parameters
given to their highlighter. I will try to look into this.
Thanks
On Sat, Feb 8, 2014 at 4:31 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Pavan Kumar Sunkara <pavan.sss1991@gmail.com> writes:
>
>> Sorry. I misunderstood your message. Yes, I guess lazy loading the
>> supported file extensions would be better. But not all highlighters
>> support `-p` option. So, I think its better to leave it to the user.
>
> Yes, those highlighters that do not support `-p` may have to rely on
> the hard-coded list %highlight_ext.
>
> But with the same line of reasoning, not all versions of highligher
> supports 'go' language, so it's better to leave that to the user,
> no? The version of 'highlight' you may have may know about 'go',
> and somebody else's 'highlight' may not yet. A hard-coded list that
> appears in %highlight_ext will be correct for only one of you while
> the other between you two needs to customize it to his system.
>
> Note that I was not talking about removing the configurability.
> Even with lazy loading and/or auto-genearting at build-install time
> when 'highlight -p' is available, the users still want to be able to
> customize, and supporting that is fine.
>
> But for those whose 'highlight' does support '-p', it will help to
> lazily discover the list of supported languages and/or enumarate
> them at build-install time. They do not have to keep adding new
> language (or removing it from the list we give as the upstream) to
> adjust it to their system.
>
> In any case, the comment was not about this patch from you, but
> about the future direction for the code it touches in general. In
> other words, it did not mean "because it does not update the
> mechanism to lazily discover the list of languages, and instead
> added yet another language to the existing one, it is not an
> acceptable solution to start supporting 'go'".
--
- Pavan Kumar Sunkara
prev parent reply other threads:[~2014-02-07 23:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-07 21:10 [PATCH] gitweb: Added syntax highlight support for golang Pavan Kumar Sunkara
2014-02-07 21:54 ` Junio C Hamano
2014-02-07 21:56 ` Pavan Kumar Sunkara
2014-02-07 21:58 ` Pavan Kumar Sunkara
2014-02-07 23:01 ` Junio C Hamano
2014-02-07 23:10 ` Pavan Kumar Sunkara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK9CXBWiaORDJaTam=X02UiBCsF2m_kW33_DqbQSLfoY1JphiQ@mail.gmail.com' \
--to=pavan.sss1991@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jnareb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).