Git 2.15.0 on OSX 10.12.6: gui multi-select stage

Git 2.15.0 on OSX 10.12.6: gui multi-select stage

[Matthew Orres]

Using 2.15.0 on OSX 10.12.6, when I open git gui, and then attempt to
stage multiple files as such:

* Left click first file
* CMD+Shift+Click last file to multi-select all files
* CMT+T (shortcut for Stage to Commit)

Only the file I selected with the first Left Click is staged and my
selection disappears.

I'd be happy to provide more system-level info if there's issues with
reproducing this on other machines.

Re: Git 2.15.0 on OSX 10.12.6: gui multi-select stage

[Johannes Schindelin]

Hi Matthew,

On Wed, 1 Nov 2017, Matthew Orres wrote:

> Using 2.15.0 on OSX 10.12.6, when I open git gui, and then attempt to
> stage multiple files as such:
> 
> * Left click first file
> * CMD+Shift+Click last file to multi-select all files
> * CMT+T (shortcut for Stage to Commit)
> 
> Only the file I selected with the first Left Click is staged and my
> selection disappears.
> 
> I'd be happy to provide more system-level info if there's issues with
> reproducing this on other machines.

Maybe you'll be also happy to test things?

I believe that we carry a fix for this in Git for Windows:
https://github.com/git-for-windows/git/commit/3a5640fd3f0aa57edecc8dab455a97c5a15e6626

The easiest way to test this would be to simply build Git from the
`master` branch of https://github.com/git-for-windows/git (I try to keep
it building and passing the test suite at all times not only on Windows,
but also on Linux, it should also work on macOS).

Ciao,
Johannes

P.S.: If you test this, and can confirm that it fixes your issue, I'll get
this patch submitted properly to the Git mailing list (sadly, it seems
that the https://github.com/patthoyts/git-gui project is sleeping beauty
mode for a while now, otherwise I would add PRs there).

Re: Git 2.15.0 on OSX 10.12.6: gui multi-select stage

[Matthew Orres]

I'd be glad to give it a try - but am unfamiliar with how portable a
manual build of Git can be used along side the version I have
installed via Homebrew - do I just use full paths to reference the
compiled executable from within my repository folder?

Thanks!

On Wed, Nov 1, 2017 at 5:58 PM, Johannes Schindelin
<Johannes.Schindelin@gmx.de> wrote:
> Hi Matthew,
>
> On Wed, 1 Nov 2017, Matthew Orres wrote:
>
>> Using 2.15.0 on OSX 10.12.6, when I open git gui, and then attempt to
>> stage multiple files as such:
>>
>> * Left click first file
>> * CMD+Shift+Click last file to multi-select all files
>> * CMT+T (shortcut for Stage to Commit)
>>
>> Only the file I selected with the first Left Click is staged and my
>> selection disappears.
>>
>> I'd be happy to provide more system-level info if there's issues with
>> reproducing this on other machines.
>
> Maybe you'll be also happy to test things?
>
> I believe that we carry a fix for this in Git for Windows:
> https://github.com/git-for-windows/git/commit/3a5640fd3f0aa57edecc8dab455a97c5a15e6626
>
> The easiest way to test this would be to simply build Git from the
> `master` branch of https://github.com/git-for-windows/git (I try to keep
> it building and passing the test suite at all times not only on Windows,
> but also on Linux, it should also work on macOS).
>
> Ciao,
> Johannes
>
> P.S.: If you test this, and can confirm that it fixes your issue, I'll get
> this patch submitted properly to the Git mailing list (sadly, it seems
> that the https://github.com/patthoyts/git-gui project is sleeping beauty
> mode for a while now, otherwise I would add PRs there).

Re: Git 2.15.0 on OSX 10.12.6: gui multi-select stage

[Johannes Schindelin]

Hi Matthew,

On Fri, 5 Jan 2018, Matthew Orres wrote:

> I'd be glad to give it a try - but am unfamiliar with how portable a
> manual build of Git can be used along side the version I have
> installed via Homebrew - do I just use full paths to reference the
> compiled executable from within my repository folder?

No. If you want to avoid installing Git, and instead want to run it
in-place after building it, you have to use --exec-path, like so:

$HOME/my-git-checkout/git --exec-path=$HOME/my-git-checkout gui

Ciao,
Johannes

Re: Git 2.15.0 on OSX 10.12.6: gui multi-select stage

[Matthew Orres]

Beautiful!

Pulled down that commit, was able to build and can confirm the issue
is fixed in git gui!

This has been a thorn in my side, so I appreciate your help! I look
forward to it being included in the next release for git in Homebrew!
:)

On Fri, Jan 5, 2018 at 4:41 PM, Johannes Schindelin <schindelin@wisc.edu> wrote:
> Hi Matthew,
>
> On Fri, 5 Jan 2018, Matthew Orres wrote:
>
>> builtin/checkout.c:24:10: fatal error: 'fscache.h' file not found
>> #include "fscache.h"
>>          ^~~~~~~~~~~
>> 1 error generated.
>
> I already had pushed a fix for this, have you re-pulled?
>
> Ciao,
> Johannes

Re: Git 2.15.0 on OSX 10.12.6: gui multi-select stage

[Johannes Schindelin]

Hi Matthew,

On Fri, 5 Jan 2018, Matthew Orres wrote:

> Beautiful!
> 
> Pulled down that commit, was able to build and can confirm the issue
> is fixed in git gui!
> 
> This has been a thorn in my side, so I appreciate your help! I look
> forward to it being included in the next release for git in Homebrew!
> :)

Well, a little bit more help from your side would be nice. For example,
you could report back *to the Git mailing list* that it helped you.
Otherwise, how is the Git maintainer to know that these commits help
anything?

Also: it is *quite* late in the release cycle right now. We are at
v2.16.0-rc1, there will be one more release candidate in the coming week,
and then the final v2.16.0 in the next week.

I highly doubt that the patches (which I still have to identify) will make
it into that release.

Ciao,
Johannes

Re: Git 2.15.0 on OSX 10.12.6: gui multi-select stage

[Johannes Schindelin]

Hi,

On Sat, 6 Jan 2018, Johannes Schindelin wrote:

> On Fri, 5 Jan 2018, Matthew Orres wrote:
> 
> > Beautiful!
> > 
> > Pulled down that commit, was able to build and can confirm the issue
> > is fixed in git gui!
> > 
> > This has been a thorn in my side, so I appreciate your help! I look
> > forward to it being included in the next release for git in Homebrew!
> > :)
> 
> Well, a little bit more help from your side would be nice. For example,
> you could report back *to the Git mailing list* that it helped you.
> Otherwise, how is the Git maintainer to know that these commits help
> anything?

Sorry, I probably need to take out my eyes and screw them in right, I
totally did not see that you Cc:ed the Git mailing list. Sorry.

> Also: it is *quite* late in the release cycle right now. We are at
> v2.16.0-rc1, there will be one more release candidate in the coming week,
> and then the final v2.16.0 in the next week.
> 
> I highly doubt that the patches (which I still have to identify) will make
> it into that release.

This is still true, though.

Ciao,
Johannes