git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Law <peterjclaw@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Completion: Add support for --submodule=diff
Date: Mon, 6 Feb 2017 22:56:09 +0000	[thread overview]
Message-ID: <CAKoneTL3-1ohv22mm-RpZ-2sNbFeAV62wOS-JoE0r2Dcn_2E3A@mail.gmail.com> (raw)
In-Reply-To: <xmqq4m0gtakk.fsf@gitster.mtv.corp.google.com>

Hi,

Junio C Hamano <gitster@pobox.com> wrote:
> Peter Law <peterjclaw@gmail.com> writes:
>
>>> Teach git-completion.bash about the 'diff' option to 'git diff
>>> --submodule=', which was added in Git 2.11.
>>
>> I posted this patch back in December, but I've not heard anything. I'm
>> sure as maintainers you're all quite busy, but I was wondering how
>> long it usually takes to get a response to patches? (also whether I'd
>> gotten some part of the submission process wrong?)
>
> When there is clear "subsystem maintainer(s)" in the area, I try to
> refrain from commenting until they speak up, and completion scripts
> are one of these areas.  I usually ping them after a few days but in
> December with holidays and things people are usually slow, and so
> was I X-<.
>
> Will pick it up.  Thanks for a reminder; you absolutely did the
> right thing (i.e. sending it out with people who are likely to know
> about the area CC'ed, waiting for a while and then sending a
> reminder).

Awesome, many thanks!

Peter

  reply	other threads:[~2017-02-06 22:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-04 14:41 [PATCH] Completion: Add support for --submodule=diff peterjclaw
2017-01-30 21:13 ` Peter Law
2017-01-30 21:43   ` Brandon Williams
2017-01-30 23:03   ` Junio C Hamano
2017-02-06 22:56     ` Peter Law [this message]
2017-01-31  0:10 ` Jacob Keller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKoneTL3-1ohv22mm-RpZ-2sNbFeAV62wOS-JoE0r2Dcn_2E3A@mail.gmail.com \
    --to=peterjclaw@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).