* [PATCH] Completion: Add support for --submodule=diff
@ 2016-12-04 14:41 peterjclaw
2017-01-30 21:13 ` Peter Law
2017-01-31 0:10 ` Jacob Keller
0 siblings, 2 replies; 6+ messages in thread
From: peterjclaw @ 2016-12-04 14:41 UTC (permalink / raw)
To: git; +Cc: jacob.keller, gitster, szeder, Peter Law
From: Peter Law <PeterJCLaw@gmail.com>
Teach git-completion.bash about the 'diff' option to 'git diff
--submodule=', which was added in Git 2.11.
Signed-off-by: Peter Law <PeterJCLaw@gmail.com>
---
contrib/completion/git-completion.bash | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 21016bf8d..ab11e7371 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -1206,7 +1206,7 @@ _git_describe ()
__git_diff_algorithms="myers minimal patience histogram"
-__git_diff_submodule_formats="log short"
+__git_diff_submodule_formats="diff log short"
__git_diff_common_options="--stat --numstat --shortstat --summary
--patch-with-stat --name-only --name-status --color
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] Completion: Add support for --submodule=diff
2016-12-04 14:41 [PATCH] Completion: Add support for --submodule=diff peterjclaw
@ 2017-01-30 21:13 ` Peter Law
2017-01-30 21:43 ` Brandon Williams
2017-01-30 23:03 ` Junio C Hamano
2017-01-31 0:10 ` Jacob Keller
1 sibling, 2 replies; 6+ messages in thread
From: Peter Law @ 2017-01-30 21:13 UTC (permalink / raw)
To: git; +Cc: Jacob Keller, Junio C Hamano, szeder
Hi,
> Teach git-completion.bash about the 'diff' option to 'git diff
> --submodule=', which was added in Git 2.11.
I posted this patch back in December, but I've not heard anything. I'm
sure as maintainers you're all quite busy, but I was wondering how
long it usually takes to get a response to patches? (also whether I'd
gotten some part of the submission process wrong?)
Thanks,
Peter
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Completion: Add support for --submodule=diff
2017-01-30 21:13 ` Peter Law
@ 2017-01-30 21:43 ` Brandon Williams
2017-01-30 23:03 ` Junio C Hamano
1 sibling, 0 replies; 6+ messages in thread
From: Brandon Williams @ 2017-01-30 21:43 UTC (permalink / raw)
To: Peter Law; +Cc: git, Jacob Keller, Junio C Hamano, szeder
On 01/30, Peter Law wrote:
> Hi,
>
> > Teach git-completion.bash about the 'diff' option to 'git diff
> > --submodule=', which was added in Git 2.11.
>
> I posted this patch back in December, but I've not heard anything. I'm
> sure as maintainers you're all quite busy, but I was wondering how
> long it usually takes to get a response to patches? (also whether I'd
> gotten some part of the submission process wrong?)
>
> Thanks,
> Peter
It looks like this must have just fallen through the cracks. Your patch
looks good to me and works when I test it locally.
--
Brandon Williams
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Completion: Add support for --submodule=diff
2017-01-30 21:13 ` Peter Law
2017-01-30 21:43 ` Brandon Williams
@ 2017-01-30 23:03 ` Junio C Hamano
2017-02-06 22:56 ` Peter Law
1 sibling, 1 reply; 6+ messages in thread
From: Junio C Hamano @ 2017-01-30 23:03 UTC (permalink / raw)
To: Peter Law; +Cc: git, Jacob Keller, szeder
Peter Law <peterjclaw@gmail.com> writes:
>> Teach git-completion.bash about the 'diff' option to 'git diff
>> --submodule=', which was added in Git 2.11.
>
> I posted this patch back in December, but I've not heard anything. I'm
> sure as maintainers you're all quite busy, but I was wondering how
> long it usually takes to get a response to patches? (also whether I'd
> gotten some part of the submission process wrong?)
When there is clear "subsystem maintainer(s)" in the area, I try to
refrain from commenting until they speak up, and completion scripts
are one of these areas. I usually ping them after a few days but in
December with holidays and things people are usually slow, and so
was I X-<.
Will pick it up. Thanks for a reminder; you absolutely did the
right thing (i.e. sending it out with people who are likely to know
about the area CC'ed, waiting for a while and then sending a
reminder).
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Completion: Add support for --submodule=diff
2017-01-30 23:03 ` Junio C Hamano
@ 2017-02-06 22:56 ` Peter Law
0 siblings, 0 replies; 6+ messages in thread
From: Peter Law @ 2017-02-06 22:56 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git
Hi,
Junio C Hamano <gitster@pobox.com> wrote:
> Peter Law <peterjclaw@gmail.com> writes:
>
>>> Teach git-completion.bash about the 'diff' option to 'git diff
>>> --submodule=', which was added in Git 2.11.
>>
>> I posted this patch back in December, but I've not heard anything. I'm
>> sure as maintainers you're all quite busy, but I was wondering how
>> long it usually takes to get a response to patches? (also whether I'd
>> gotten some part of the submission process wrong?)
>
> When there is clear "subsystem maintainer(s)" in the area, I try to
> refrain from commenting until they speak up, and completion scripts
> are one of these areas. I usually ping them after a few days but in
> December with holidays and things people are usually slow, and so
> was I X-<.
>
> Will pick it up. Thanks for a reminder; you absolutely did the
> right thing (i.e. sending it out with people who are likely to know
> about the area CC'ed, waiting for a while and then sending a
> reminder).
Awesome, many thanks!
Peter
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Completion: Add support for --submodule=diff
2016-12-04 14:41 [PATCH] Completion: Add support for --submodule=diff peterjclaw
2017-01-30 21:13 ` Peter Law
@ 2017-01-31 0:10 ` Jacob Keller
1 sibling, 0 replies; 6+ messages in thread
From: Jacob Keller @ 2017-01-31 0:10 UTC (permalink / raw)
To: peterjclaw; +Cc: Git mailing list, Junio C Hamano, SZEDER Gábor
On Sun, Dec 4, 2016 at 6:41 AM, <peterjclaw@gmail.com> wrote:
> From: Peter Law <PeterJCLaw@gmail.com>
>
> Teach git-completion.bash about the 'diff' option to 'git diff
> --submodule=', which was added in Git 2.11.
>
> Signed-off-by: Peter Law <PeterJCLaw@gmail.com>
> ---
> contrib/completion/git-completion.bash | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index 21016bf8d..ab11e7371 100644
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -1206,7 +1206,7 @@ _git_describe ()
>
> __git_diff_algorithms="myers minimal patience histogram"
>
> -__git_diff_submodule_formats="log short"
> +__git_diff_submodule_formats="diff log short"
>
> __git_diff_common_options="--stat --numstat --shortstat --summary
> --patch-with-stat --name-only --name-status --color
> --
> 2.11.0
>
Yep, this looks good to me.
Thanks,
Jake
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-02-06 22:56 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-04 14:41 [PATCH] Completion: Add support for --submodule=diff peterjclaw
2017-01-30 21:13 ` Peter Law
2017-01-30 21:43 ` Brandon Williams
2017-01-30 23:03 ` Junio C Hamano
2017-02-06 22:56 ` Peter Law
2017-01-31 0:10 ` Jacob Keller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).