git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rohit Ashiwal <rohit.ashiwal265@gmail.com>
To: "gitgitgadget/git" 
	<reply+01d9b0f6af7d837348ddd5ec643fae63e61359ee3638c02692cf00000001188e257692a169ce18b2a661@reply.github.com>
Cc: pclouds@gmail.com,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	git <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>,
	Christian Couder <christian.couder@gmail.com>
Subject: Re: [gitgitgadget/git] [GSoC][PATCH] t3600: `use test_path_is_*` helper functions (#152)
Date: Thu, 28 Feb 2019 16:06:38 +0530	[thread overview]
Message-ID: <CAL7ArXp2VWmYmKZ2io8aV_gwMKYPsjeB+5aijbHTPxSfrYTYnA@mail.gmail.com> (raw)
In-Reply-To: <gitgitgadget/git/pull/152/review/208437870@github.com>

Hey Duy

>
> On the Git mailing list, Duy Nguyen wrote (reply to this):
>
> I was a bit worried that the "test ! something" could be incorrectly
> converted because for example, "test ! -d foo" is not always the same
> as "test_path_is_missing". If "foo" is intended to be a file, then the
> conversion is wrong.
>
> But I don't think you made any wrong conversion here. All these
> negative "test" are preceded by "git rm" so the expectation is always
> "test ! -e".
>

Sorry for the late reply. Yes, I thought about it earlier and made
changes thinking this only. Also when I was going through the code
again, I replaced other conditionals `[ -f ]` with test_path_is_file
etc.

Ciao
Rohit

           reply	other threads:[~2019-02-28 10:37 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <gitgitgadget/git/pull/152/review/208437870@github.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAL7ArXp2VWmYmKZ2io8aV_gwMKYPsjeB+5aijbHTPxSfrYTYnA@mail.gmail.com \
    --to=rohit.ashiwal265@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=pclouds@gmail.com \
    --cc=reply+01d9b0f6af7d837348ddd5ec643fae63e61359ee3638c02692cf00000001188e257692a169ce18b2a661@reply.github.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).