* Re: [gitgitgadget/git] [GSoC][PATCH] t3600: `use test_path_is_*` helper functions (#152)
[not found] ` <gitgitgadget/git/pull/152/review/208437870@github.com>
@ 2019-02-28 10:36 ` Rohit Ashiwal
0 siblings, 0 replies; only message in thread
From: Rohit Ashiwal @ 2019-02-28 10:36 UTC (permalink / raw)
To: gitgitgadget/git
Cc: pclouds, Johannes Schindelin, git, Junio C Hamano,
Christian Couder
Hey Duy
>
> On the Git mailing list, Duy Nguyen wrote (reply to this):
>
> I was a bit worried that the "test ! something" could be incorrectly
> converted because for example, "test ! -d foo" is not always the same
> as "test_path_is_missing". If "foo" is intended to be a file, then the
> conversion is wrong.
>
> But I don't think you made any wrong conversion here. All these
> negative "test" are preceded by "git rm" so the expectation is always
> "test ! -e".
>
Sorry for the late reply. Yes, I thought about it earlier and made
changes thinking this only. Also when I was going through the code
again, I replaced other conditionals `[ -f ]` with test_path_is_file
etc.
Ciao
Rohit
^ permalink raw reply [flat|nested] only message in thread