From: Ronnie Sahlberg <sahlberg@google.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>,
Michael Haggerty <mhagger@alum.mit.edu>
Subject: Re: [PATCH v4 00/27] Use ref transactions for all ref updates
Date: Tue, 29 Apr 2014 15:24:50 -0700 [thread overview]
Message-ID: <CAL=YDWkv_XEXCpuAE8inD6Lj5NNHOEf9womimE70AxinO1Ufng@mail.gmail.com> (raw)
In-Reply-To: <xmqq4n1bke4b.fsf@gitster.dls.corp.google.com>
On Tue, Apr 29, 2014 at 2:41 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Ronnie Sahlberg <sahlberg@google.com> writes:
>
>> This patch series is based on mhagger/ref-transactions and expands on the
>> transaction API. It converts all external (outside of refs.c) callers to
>> use the transaction API for any writes.
>> This makes most of the ref updates to become atomic when there are failures
>> locking or writing to a ref.
>
> I think I saw some more comments to be addressed on this round, but
> I'll try to push it through into 'pu' by attempting to resolve
> conflicts so that I can ask you to eyeball the result. This series
> seem to conflict with your own rs/ref-update-check-errors-early
> topic that is already in 'next'.
>
> If I screwed up the conflict resolution (which is very possible), I
> may have to ask you to rebase this series on top of acc62aa (which
> is the merge of rs/ref-update-check-errors-early to 'next'), but I
> am hoping that conflict resolution I'll push out today will be
> correct. We'll see.
>
Thanks.
I just sent v5 of the patch series where I have addressed the comments from
Eric and Michael so far.
Otherwise, how hard would it be to drop
rs/ref-update-check-errors-early ?
I can just redo those patches later, and that might be the easiest solution.
Regards
ronnie sahlberg
> Thanks.
prev parent reply other threads:[~2014-04-29 22:24 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-28 22:54 [PATCH v4 00/27] Use ref transactions for all ref updates Ronnie Sahlberg
2014-04-28 22:54 ` [PATCH v4 01/27] refs.c: constify the sha arguments for ref_transaction_create|delete|update Ronnie Sahlberg
2014-04-28 22:54 ` [PATCH v4 02/27] refs.c: allow passing NULL to ref_transaction_free Ronnie Sahlberg
2014-04-28 22:54 ` [PATCH v4 03/27] refs.c: add a strbuf argument to ref_transaction_commit for error logging Ronnie Sahlberg
2014-04-28 22:54 ` [PATCH v4 04/27] refs.c: make ref_update_reject_duplicates take a strbuf argument for errors Ronnie Sahlberg
2014-04-28 22:54 ` [PATCH v4 05/27] update-ref.c: log transaction error from the update_ref Ronnie Sahlberg
2014-04-28 22:54 ` [PATCH v4 06/27] refs.c: make update_ref_write update a strbuf on failure Ronnie Sahlberg
2014-04-28 22:54 ` [PATCH v4 07/27] refs.c: remove the onerr argument to ref_transaction_commit Ronnie Sahlberg
2014-04-28 22:54 ` [PATCH v4 08/27] refs.c: change ref_transaction_update() to do error checking and return status Ronnie Sahlberg
2014-04-29 0:51 ` Eric Sunshine
2014-04-29 16:05 ` Ronnie Sahlberg
2014-04-28 22:54 ` [PATCH v4 09/27] refs.c: change ref_transaction_create " Ronnie Sahlberg
2014-04-28 22:54 ` [PATCH v4 10/27] refs.c: ref_transaction_delete to check for error " Ronnie Sahlberg
2014-04-28 22:54 ` [PATCH v4 11/27] tag.c: use ref transactions when doing updates Ronnie Sahlberg
2014-04-28 22:54 ` [PATCH v4 12/27] replace.c: use the ref transaction functions for updates Ronnie Sahlberg
2014-04-29 0:44 ` Eric Sunshine
2014-04-29 16:18 ` Ronnie Sahlberg
2014-04-29 18:29 ` Eric Sunshine
2014-04-28 22:54 ` [PATCH v4 13/27] commit.c: use ref transactions " Ronnie Sahlberg
2014-04-28 22:54 ` [PATCH v4 14/27] sequencer.c: use ref transactions for all ref updates Ronnie Sahlberg
2014-04-28 22:54 ` [PATCH v4 15/27] fast-import.c: change update_branch to use ref transactions Ronnie Sahlberg
2014-04-29 2:18 ` Eric Sunshine
2014-04-29 16:57 ` Ronnie Sahlberg
2014-04-29 22:10 ` Junio C Hamano
2014-04-28 22:54 ` [PATCH v4 16/27] branch.c: use ref transaction for all ref updates Ronnie Sahlberg
2014-04-28 22:54 ` [PATCH v4 17/27] refs.c: change update_ref to use a transaction Ronnie Sahlberg
2014-04-28 22:54 ` [PATCH v4 18/27] refs.c: free the transaction before returning when number of updates is 0 Ronnie Sahlberg
2014-04-28 22:54 ` [PATCH v4 19/27] refs.c: ref_transaction_commit should not free the transaction Ronnie Sahlberg
2014-04-28 22:54 ` [PATCH v4 20/27] fetch.c: clear errno before calling functions that might set it Ronnie Sahlberg
2014-04-28 22:54 ` [PATCH v4 21/27] fetch.c: change s_update_ref to use a ref transaction Ronnie Sahlberg
2014-04-28 22:54 ` [PATCH v4 22/27] fetch.c: use a single ref transaction for all ref updates Ronnie Sahlberg
2014-04-28 22:54 ` [PATCH v4 23/27] receive-pack.c: use a reference transaction for updating the refs Ronnie Sahlberg
2014-04-28 22:54 ` [PATCH v4 24/27] fast-import.c: use a ref transaction when dumping tags Ronnie Sahlberg
2014-04-28 22:54 ` [PATCH v4 25/27] walker.c: use ref transaction for ref updates Ronnie Sahlberg
2014-04-28 22:54 ` [PATCH v4 26/27] refs.c: make write_ref_sha1 static Ronnie Sahlberg
2014-04-28 22:54 ` [PATCH v4 27/27] refs.c: make lock_ref_sha1 static Ronnie Sahlberg
2014-04-29 21:41 ` [PATCH v4 00/27] Use ref transactions for all ref updates Junio C Hamano
2014-04-29 22:24 ` Ronnie Sahlberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL=YDWkv_XEXCpuAE8inD6Lj5NNHOEf9womimE70AxinO1Ufng@mail.gmail.com' \
--to=sahlberg@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mhagger@alum.mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).