From: Johan Herland <johan@herland.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Eric Sunshine <sunshine@sunshineco.com>,
Git List <git@vger.kernel.org>,
"Kyle J. McKay" <mackyle@gmail.com>,
"James H. Fisher" <jhf@trifork.com>, Jeff King <peff@peff.net>,
Michael Blume <blume.mike@gmail.com>
Subject: Re: [PATCHv5 9/9] t3301: Modernize
Date: Thu, 13 Nov 2014 00:43:41 +0100 [thread overview]
Message-ID: <CALKQrge2FM79XQy14jEYQBY+DwQ9xpcC-yMmKk1kE-yJixzJVw@mail.gmail.com> (raw)
In-Reply-To: <xmqq389o3yop.fsf@gitster.dls.corp.google.com>
On Wed, Nov 12, 2014 at 10:18 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Johan Herland <johan@herland.net> writes:
>> On Wed, Nov 12, 2014 at 2:57 AM, Eric Sunshine <sunshine@sunshineco.com> wrote:
>>> On Tue, Nov 11, 2014 at 7:40 PM, Johan Herland <johan@herland.net> wrote:
>>>> + test_line_count = 1 actual
>>>
>>> Broken &&-chain. This problem is repeated each place use invoke
>>> test_line_count().
>>
>> Thanks. Fixed in the next iteration.
>
> Just FYI, here is what I came up with on top of 9/9 as 10/9, and it
> can be squashed in. If these will be the only differences between
> v5 and upcoming v6, you can just tell me to squash them together.
So far this is the only diff on top of v5. I've squashed it into my
tree, so if a re-roll is needed, this diff will also be part of it.
But if no other issues show up to trigger a re-roll, then please
squash them on your end as well.
> One unrelated changes is that '\'' is a bit shorter than '"'"' (and
> the four-letter sequence is idiomatic and easier to spot, once your
> eyes are used to reading strings in single-quote pairs).
Agreed, thanks.
...Johan
--
Johan Herland, <johan@herland.net>
www.herland.net
prev parent reply other threads:[~2014-11-12 23:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-12 0:40 [PATCHv5 0/9] Handling empty notes Johan Herland
2014-11-12 0:40 ` [PATCHv5 1/9] builtin/notes: Fix premature failure when trying to add the empty blob Johan Herland
2014-11-12 0:40 ` [PATCHv5 2/9] t3301: Verify that 'git notes' removes empty notes by default Johan Herland
2014-11-12 0:40 ` [PATCHv5 3/9] builtin/notes: Improve naming Johan Herland
2014-11-12 0:40 ` [PATCHv5 4/9] builtin/notes: Refactor note file path into struct note_data Johan Herland
2014-11-12 0:40 ` [PATCHv5 5/9] builtin/notes: Simplify early exit code in add() Johan Herland
2014-11-12 0:40 ` [PATCHv5 6/9] builtin/notes: Split create_note() to clarify add vs. remove logic Johan Herland
2014-11-12 0:40 ` [PATCHv5 7/9] builtin/notes: Add --allow-empty, to allow storing empty notes Johan Herland
2014-11-12 0:40 ` [PATCHv5 8/9] notes: Empty notes should be shown by 'git log' Johan Herland
2014-11-12 0:40 ` [PATCHv5 9/9] t3301: Modernize Johan Herland
2014-11-12 1:57 ` Eric Sunshine
2014-11-12 9:08 ` Johan Herland
2014-11-12 21:18 ` Junio C Hamano
2014-11-12 23:43 ` Johan Herland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALKQrge2FM79XQy14jEYQBY+DwQ9xpcC-yMmKk1kE-yJixzJVw@mail.gmail.com \
--to=johan@herland.net \
--cc=blume.mike@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jhf@trifork.com \
--cc=mackyle@gmail.com \
--cc=peff@peff.net \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).