From: Lex Spoon <lex@lexspoon.org>
To: Luke Diamand <luke@diamand.org>
Cc: Git Users <git@vger.kernel.org>
Subject: Re: [PATCH] git-p4: add failing tests for case-folding p4d
Date: Tue, 28 Apr 2015 19:01:46 -0400 [thread overview]
Message-ID: <CALM2Sna0OqxYWzEj94SY61ZsL8cB+SyuiJ0EsAzq+kbiw87QLQ@mail.gmail.com> (raw)
In-Reply-To: <1430212081-16146-2-git-send-email-luke@diamand.org>
The last comment in the test took me a minute to decipher. I would
suggest "no repo path called LC" instead of "no repo called LC". Also,
it would have helped me to either have a little comment on the "UC"
version of the test, or to make the previous comment a little more
neutral so that it will apply to both test cases.
Otherwise, while I am not a regular maintainer of this code, the patch
does LGTM. Certainly it's good to have more test coverage.
For the underlying problem, I haven't thought about it very much, but
it looks like a plausible first step might be to simply probe the
given file name and see if it comes back the same way. If it comes
back differently, then maybe the command should abort?
What a tough problem all around...
Lex
next prev parent reply other threads:[~2015-04-28 23:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-28 9:08 [PATCH] git-p4: add failing tests for case-folding in p4d Luke Diamand
2015-04-28 9:08 ` [PATCH] git-p4: add failing tests for case-folding p4d Luke Diamand
2015-04-28 23:01 ` Lex Spoon [this message]
2015-04-29 8:19 ` Luke Diamand
2015-04-28 9:19 ` [PATCH] git-p4: add failing tests for case-folding in p4d Luke Diamand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALM2Sna0OqxYWzEj94SY61ZsL8cB+SyuiJ0EsAzq+kbiw87QLQ@mail.gmail.com \
--to=lex@lexspoon.org \
--cc=git@vger.kernel.org \
--cc=luke@diamand.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).