From: "Felipe Gonçalves Assis" <felipeg.assis@gmail.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: "Git List" <git@vger.kernel.org>,
"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
"Junio C Hamano" <gitster@pobox.com>,
"Felipe Gonçalves Assis" <felipegassis@gmail.com>
Subject: Re: [PATCH v3 0/2] merge-recursive: option to disable renames
Date: Wed, 17 Feb 2016 01:38:23 -0200 [thread overview]
Message-ID: <CALMa68oy2i6GeiUS1MLodAJ__TsqDzbRWcFVY2xdZKcoONKvzA@mail.gmail.com> (raw)
In-Reply-To: <CAPig+cRhbCRJhrOFcjY2avFZ0rQgCP-JT-6RTCiihOQB8nWeMw@mail.gmail.com>
On 16 February 2016 at 23:37, Eric Sunshine <sunshine@sunshineco.com> wrote:
> On Tue, Feb 16, 2016 at 8:11 PM, Felipe Gonçalves Assis
> <felipeg.assis@gmail.com> wrote:
>> No more renames option. rename-threshold enables renames.
>
> Can you add some tests? Off the top of my head, I'd expect to see at
> least three new tests:
>
> 1. --no-renames works as expected
> 2. last wins in "--no-renames --rename-threshold=x"
> 3. last wins in "--rename-threshold=x --no-renames"
>
Sure.
Just a heads up: For the next three days I will have very little time,
so I will start tackling this on the weekend. I submitted a fourth
version of the patch without the tests, so that this part of the work
can proceed in parallel.
Thanks,
Felipe
prev parent reply other threads:[~2016-02-17 3:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-17 1:11 [PATCH v3 0/2] merge-recursive: option to disable renames Felipe Gonçalves Assis
2016-02-17 1:11 ` [PATCH v3 1/2] " Felipe Gonçalves Assis
2016-02-17 1:41 ` Eric Sunshine
2016-02-17 3:16 ` Felipe Gonçalves Assis
2016-02-17 1:11 ` [PATCH v3 2/2] merge-recursive: more consistent interface Felipe Gonçalves Assis
2016-02-17 1:52 ` Eric Sunshine
2016-02-17 1:37 ` [PATCH v3 0/2] merge-recursive: option to disable renames Eric Sunshine
2016-02-17 3:38 ` Felipe Gonçalves Assis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALMa68oy2i6GeiUS1MLodAJ__TsqDzbRWcFVY2xdZKcoONKvzA@mail.gmail.com \
--to=felipeg.assis@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=felipegassis@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).