From: Alexander Pyhalov <apyhalov@gmail.com>
To: git@vger.kernel.org
Subject: t7005-editor.sh failure
Date: Wed, 26 Sep 2018 09:52:12 +0300 [thread overview]
Message-ID: <CALOYryFX4PPR+=1L+sjEqPsdmNh_+vNxGf0wwuAgoYzau=GShw@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 406 bytes --]
On updating git to 2.19 we've suddenly got t7005-editor.sh test failures.
The issue seems to be that generated "e space.sh" file can't handle
files with spaces.
Instead of 'echo space >$1' it should be 'echo space > "$1"' or git
editor fails when gets file with spaces in name.
The patch is simple:
--
Best regards,
Alexander Pyhalov,
system administrator of Southern Federal University IT department
[-- Attachment #2: 0005-t7005-editor.sh.patch --]
[-- Type: text/x-patch, Size: 413 bytes --]
--- git-2.19.0/t/t7005-editor.sh.~1~ Mon Sep 10 21:39:13 2018
+++ git-2.19.0/t/t7005-editor.sh Wed Sep 26 09:41:30 2018
@@ -112,7 +112,7 @@
done
test_expect_success 'editor with a space' '
- echo "echo space >\$1" >"e space.sh" &&
+ echo "echo space > \"\$1\"" > "e space.sh" &&
chmod a+x "e space.sh" &&
GIT_EDITOR="./e\ space.sh" git commit --amend &&
test space = "$(git show -s --pretty=format:%s)"
next reply other threads:[~2018-09-26 6:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-26 6:52 Alexander Pyhalov [this message]
2018-09-26 7:59 ` t7005-editor.sh failure Martin Ågren
2018-09-26 9:00 ` Alexander Pyhalov
2018-09-26 9:52 ` Martin Ågren
2018-09-26 10:02 ` Alexander Pyhalov
2018-09-26 11:59 ` Eric Sunshine
2018-09-26 13:23 ` Martin Ågren
2018-09-26 12:11 ` SZEDER Gábor
2018-09-26 16:14 ` [PATCH] t7005-editor: quote filename to fix whitespace-issue Martin Ågren
2018-09-26 18:14 ` Taylor Blau
2018-09-26 19:21 ` Jeff King
2018-09-26 18:16 ` t7005-editor.sh failure Junio C Hamano
2018-09-26 19:16 ` Junio C Hamano
2018-09-26 19:29 ` Andrei Rybak
2018-09-27 20:53 ` SZEDER Gábor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALOYryFX4PPR+=1L+sjEqPsdmNh_+vNxGf0wwuAgoYzau=GShw@mail.gmail.com' \
--to=apyhalov@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).