From: Tay Ray Chuan <rctay89@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH v2 0/2] make commit --verbose work with --no-status
Date: Sat, 6 Jun 2015 00:48:35 +0800 [thread overview]
Message-ID: <CALUzUxrFvE-SDW0q2P08vR7rc4GHdpm24y7dk+kUdyGGwmqwOQ@mail.gmail.com> (raw)
In-Reply-To: <xmqqbnguta69.fsf@gitster.dls.corp.google.com>
On Sat, Jun 6, 2015 at 12:03 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Tay Ray Chuan <rctay89@gmail.com> writes:
>
>> Would it be a good idea to have a --diff-only option to include diff,
>> but not status output? Or perhaps a --diff option, while leaving it to
>> the user to specify if status output is to be included with
>> --no-status, which would open the doors for mixing and matching status
>> formatting control, eg. with --short.
>
> The name "--diff-only" does not sound right, as people would wonder
> what should happen when you give "--status --diff-only".
>
> Perhaps you would need to do some careful thinking, similar to what
> we did when deciding the "diff" and "log" options.
>
> We originally had "--patch" and then "--patch-with-stat" to "diff"
> and "log", but soon after that people found that "show only stat
> without the patch text" is a useful thing to do. We retrofitted the
> command line parser to take "--patch" and "--stat" as orthogonal but
> inter-related options, which was a successful conversion that did
> not break backward compatibility (These days people would not even
> know that these strangely combined forms "--patch-with-stat" and
> "--patch-with-raw" even exist).
>
> All of the above assumes that showing only the patch and not other
> hints to help situation awareness while making a commit is a useful
> thing in the first place. I am undecided on that point myself.
Hmm, perhaps such functionality should be off-loaded to a third-party
wrapper. (I'd not be surprised if most wrappers already have this.)
--
Cheers,
Ray Chuan
next prev parent reply other threads:[~2015-06-05 16:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-04 17:56 [PATCH v2 0/2] make commit --verbose work with --no-status Tay Ray Chuan
2015-06-04 17:56 ` [PATCH v2 1/2] extract setting of wt_status.commitable flag out of wt_status_print_updated() Tay Ray Chuan
2015-06-04 17:56 ` [PATCH v2 2/2] make commit --verbose work with --no-status Tay Ray Chuan
2015-06-04 21:34 ` [PATCH v2 1/2] extract setting of wt_status.commitable flag out of wt_status_print_updated() Junio C Hamano
2015-06-04 18:39 ` [PATCH v2 0/2] make commit --verbose work with --no-status Junio C Hamano
2015-06-05 12:40 ` Tay Ray Chuan
2015-06-05 16:03 ` Junio C Hamano
2015-06-05 16:48 ` Tay Ray Chuan [this message]
2015-06-05 17:13 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALUzUxrFvE-SDW0q2P08vR7rc4GHdpm24y7dk+kUdyGGwmqwOQ@mail.gmail.com \
--to=rctay89@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).