git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Antoine Pelisse <apelisse@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Mathieu Liénard--Mayor" <mathieu.lienard--mayor@ensimag.fr>,
	"Célestin Matte" <celestin.matte@ensimag.fr>,
	"Linus Torvalds" <torvalds@linux-foundation.org>,
	"Git Users" <git@vger.kernel.org>,
	Jorge-Juan.Garcia-Garcia@ensimag.imag.fr,
	"Matthieu Moy" <Matthieu.Moy@grenoble-inp.fr>
Subject: Re: New feature discussion: git rebase --status
Date: Thu, 13 Jun 2013 07:52:56 +0200	[thread overview]
Message-ID: <CALWbr2x-4_QSurvScYL+2Utn=-K3Knb7Kif9SAvV_V-ZdvPfCw@mail.gmail.com> (raw)
In-Reply-To: <7vzjuvynt0.fsf@alter.siamese.dyndns.org>

On Thu, Jun 13, 2013 at 12:19 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Antoine Pelisse <apelisse@gmail.com> writes:
>
>> Maybe we can display previous and next commits to provide some
>> context. Like we do for diff.
>> For example:
>>
>> $ git status
>> # HEAD detached from ecb9f3e
>> # Already applied 330 patches (displaying next 3):
>> #     b170635... my_commit_message
>> #     b170635... my_commit_message
>> #     b170635... my_commit_message
>> # Already applied 119 (displaying last 3)
>> #     b170635... my_commit_message
>> #     b170635... my_commit_message
>> #     b170635... my_commit_message
>
> I think you meant one of them to be
>
>     # Still to be applied 119 (showing the first 3)
>
> instead.

Of course,

> I am not sure if it is worth 8 lines, especially given
> that "git log --oneline -$n" would give you "Already applied" part
> that is beyond what will be shown in this message easily if you
> wanted to.  So it might be enough to show "The one that has last
> been replayed" (aka "HEAD") and "The one you are in the middle of
> replaying".

That's very true. The piece of information that is hard to get is
"what's left to be done".

So something like this would make sense:

$ git status
# HEAD detached from ecb9f3e
# You are currently editing a832578... my_commit_message [120/450]
while rebasing.
# 320 patches left to apply (showing next 3):
#       b170635... my_commit_message
#       b170635... my_commit_message
#       b170635... my_commit_message
#   (use "git commit --amend" to amend the current commit)
#   (use "git rebase --continue" once you are satisfied with your changes)

So that's 4 extra lines compared to current output. But should we make
it a default ?

  reply	other threads:[~2013-06-13  5:53 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-11 12:35 New feature discussion: git rebase --status Mathieu Liénard--Mayor
2013-06-11 12:40 ` Thomas Rast
2013-06-11 12:55 ` John Keeping
2013-06-11 13:19   ` Matthieu Moy
2013-06-11 17:18     ` Hilco Wijbenga
2013-06-11 17:23       ` Linus Torvalds
2013-06-12 10:17         ` Mathieu Liénard--Mayor
2013-06-12 11:12           ` Célestin Matte
2013-06-12 11:23             ` Mathieu Liénard--Mayor
2013-06-12 12:28               ` Antoine Pelisse
     [not found]                 ` <CAH_OBifOeSSWB-LPT=Zv2AGEf5+nTh7yxE-1ijD0snFp3RS8Dw@mail.gmail.com>
2013-06-12 12:50                   ` Mathieu Liénard--Mayor
2013-06-12 22:19                 ` Junio C Hamano
2013-06-13  5:52                   ` Antoine Pelisse [this message]
2013-06-13 12:19                     ` Mathieu Liénard--Mayor
2013-06-12 12:41           ` Matthieu Moy
2013-06-12 12:52             ` John Keeping

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALWbr2x-4_QSurvScYL+2Utn=-K3Knb7Kif9SAvV_V-ZdvPfCw@mail.gmail.com' \
    --to=apelisse@gmail.com \
    --cc=Jorge-Juan.Garcia-Garcia@ensimag.imag.fr \
    --cc=Matthieu.Moy@grenoble-inp.fr \
    --cc=celestin.matte@ensimag.fr \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=mathieu.lienard--mayor@ensimag.fr \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).