git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Antoine Pelisse <apelisse@gmail.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: git <git@vger.kernel.org>, "Jörn Hees" <dev@joernhees.de>,
	"Junio C Hamano" <gitster@pobox.com>
Subject: Re: [PATCH v2 0/2] remote-hg: shared repo upgrade fix
Date: Sat, 10 Aug 2013 17:18:11 +0200	[thread overview]
Message-ID: <CALWbr2zKhvM_scRCER2GeBtRDF2=bvrDQWc+GZjDGExHeKRnQg@mail.gmail.com> (raw)
In-Reply-To: <1376087884-32060-1-git-send-email-felipe.contreras@gmail.com>

On Sat, Aug 10, 2013 at 12:38 AM, Felipe Contreras
<felipe.contreras@gmail.com> wrote:
> Hi,
>
> Same as before, except with commit messages updated, and improved the second
> patch:
>
> --- a/contrib/remote-helpers/git-remote-hg
> +++ b/contrib/remote-helpers/git-remote-hg
> @@ -400,8 +400,9 @@ def get_repo(url, alias):
>                  local_hg = os.path.join(shared_path, x, 'clone', '.hg')
>                  if not os.path.exists(local_hg):
>                      continue
> -                shutil.copytree(local_hg, hg_path)
> -                break
> +                if not os.path.exists(hg_path):
> +                    shutil.move(local_hg, hg_path)
> +                shutil.rmtree(os.path.join(shared_path, x, 'clone'))
>
>          # setup shared repo (if not there)
>          try:

FWIW,
Reviewed-by: Antoine Pelisse <apelisse@gmail.com>

Cheers,

      parent reply	other threads:[~2013-08-10 15:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-09 22:38 [PATCH v2 0/2] remote-hg: shared repo upgrade fix Felipe Contreras
2013-08-09 22:38 ` [PATCH v2 1/2] remote-hg: ensure shared repo is initialized Felipe Contreras
2013-08-09 22:38 ` [PATCH v2 2/2] remote-hg: add shared repo upgrade Felipe Contreras
2013-08-10 15:18 ` Antoine Pelisse [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALWbr2zKhvM_scRCER2GeBtRDF2=bvrDQWc+GZjDGExHeKRnQg@mail.gmail.com' \
    --to=apelisse@gmail.com \
    --cc=dev@joernhees.de \
    --cc=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).