git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thierry Suzanne <thierry@yellownemo.com>
To: Christian Couder <christian.couder@gmail.com>
Cc: git <git@vger.kernel.org>
Subject: Re: Found possible branch point, then "Use of uninitialized value $u in substitution/concatenation"
Date: Fri, 6 May 2016 16:32:53 +0100	[thread overview]
Message-ID: <CALZdSA_Fm0oGDYgBcfH0Ohkjw2Op5czqMgy0C9Kkss6MPck_dw@mail.gmail.com> (raw)
In-Reply-To: <CAP8UFD0k0Kx306S3y-Kd5328j0MDNL+ewCJvXbsJ1nzsJYRdtg@mail.gmail.com>

Sorry, can't help :(

On 6 May 2016 at 09:27, Christian Couder <christian.couder@gmail.com> wrote:
> Hi,
>
> On Thu, May 5, 2016 at 12:43 PM, Thierry Suzanne <thierry@yellownemo.com> wrote:
>>
>> Looking at svn.pm, I can see we're in find_parent_branch() which
>> outputs the message "Found possible branch point". It then calls
>> other_gs($new_url, $url, $branch_from, $r, $self->{ref_id});
>>
>> which itself calls:
>> Git::SVN->find_by_url($new_url, $url, $branch_from);
>>
>> which calls:
>> resolve_local_globs($u, $fetch, $globspec);
>>
>> and resolve_local_globs is where the error is thrown on line 100/101:
>> my $u = (::cmt_metadata("$refname"))[0];
>> $u =~ s!^\Q$url\E(/|$)!! or die
>>
>> I made a mistake in my command line for sure, so this might not be a
>> bug, I'm just emailing all this if someone think it could be handled
>> differently or a better error shown.
>
> Yeah, there is a die() calls above and also one on line 101, so it
> looks like $u could be checked between line 100 and line 101 and die()
> could be called if it is not properly defined.
>
> Could you send a patch to do something like that?
>
> Thanks,
> Christian.

  reply	other threads:[~2016-05-06 15:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-05 10:43 Found possible branch point, then "Use of uninitialized value $u in substitution/concatenation" Thierry Suzanne
2016-05-06  8:27 ` Christian Couder
2016-05-06 15:32   ` Thierry Suzanne [this message]
     [not found]   ` <CALZdSA_eF--tdDAPwEfopioB+X=n7Xti-ixGNJqEwvDdCwo2pg@mail.gmail.com>
2016-05-07  7:07     ` Christian Couder
2016-05-09 17:35       ` Thierry Suzanne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALZdSA_Fm0oGDYgBcfH0Ohkjw2Op5czqMgy0C9Kkss6MPck_dw@mail.gmail.com \
    --to=thierry@yellownemo.com \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).