From: Ramkumar Ramachandra <artagnon@gmail.com>
To: John Keeping <john@keeping.me.uk>
Cc: Git List <git@vger.kernel.org>, Michael Haggerty <mhagger@alum.mit.edu>
Subject: Re: Review of git multimail
Date: Wed, 3 Jul 2013 03:04:19 +0530 [thread overview]
Message-ID: <CALkWK0=Hke+a9ebKYHZzo13gPTxcMSjVKFHtZa03WNgssEzvUA@mail.gmail.com> (raw)
In-Reply-To: <20130702205143.GC9161@serenity.lan>
John Keeping wrote:
> I have to say that I don't think this is a particularly useful review,
> you seem to have skipped huge portions of the code and spent a lot of
> time making us read your thought process rather than providing
> constructive feedback. What feedback there is mostly seems to be
> expressions of disgust rather than actionable points.
Well, ignore it then. I'm sorry for having wasted your time.
I did what I could in the time I was willing to spend reading it.
next prev parent reply other threads:[~2013-07-02 21:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-02 19:23 Review of git multimail Ramkumar Ramachandra
2013-07-02 20:51 ` John Keeping
2013-07-02 21:34 ` Ramkumar Ramachandra [this message]
2013-07-02 22:21 ` Junio C Hamano
2013-07-03 8:02 ` Michael Haggerty
2013-07-03 8:16 ` Junio C Hamano
2013-07-03 8:29 ` John Keeping
2013-07-03 8:33 ` John Keeping
2013-07-03 0:10 ` Michael Haggerty
2013-07-03 10:23 ` Ramkumar Ramachandra
2013-07-03 11:02 ` Ramkumar Ramachandra
2013-07-03 11:41 ` Michael Haggerty
2013-07-03 21:09 ` Jed Brown
2013-07-04 8:11 ` Matthieu Moy
2013-07-04 8:27 ` Michael Haggerty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALkWK0=Hke+a9ebKYHZzo13gPTxcMSjVKFHtZa03WNgssEzvUA@mail.gmail.com' \
--to=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=john@keeping.me.uk \
--cc=mhagger@alum.mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).