From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ramkumar Ramachandra Subject: Re: Review of git multimail Date: Wed, 3 Jul 2013 03:04:19 +0530 Message-ID: References: <1372793019-12162-1-git-send-email-artagnon@gmail.com> <20130702205143.GC9161@serenity.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: Git List , Michael Haggerty To: John Keeping X-From: git-owner@vger.kernel.org Tue Jul 02 23:35:05 2013 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Uu8E4-0006Se-R0 for gcvg-git-2@plane.gmane.org; Tue, 02 Jul 2013 23:35:05 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754733Ab3GBVfA (ORCPT ); Tue, 2 Jul 2013 17:35:00 -0400 Received: from mail-ie0-f180.google.com ([209.85.223.180]:42335 "EHLO mail-ie0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752758Ab3GBVe7 (ORCPT ); Tue, 2 Jul 2013 17:34:59 -0400 Received: by mail-ie0-f180.google.com with SMTP id f4so12469161iea.25 for ; Tue, 02 Jul 2013 14:34:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=srjd8ccxXtwuZZdnue+kPl5fYf4AyJYCVYu2JetMuWc=; b=HGan4cG4mYY6Q1mb3gFiVxMPA6IPw4UnnO+8iOrWfgwf6tbppqDVaY1wo8qRaIxolr Y99h+yr6i15iPL2ACemKedcM57YnZ+XLAkw82a3E08HR0dh0dg5BZDGnRMoivybrcEz1 QHnD3xWOY1zzSziGxbjz8VHL02MYHr67ZdyXzQ8RjwmQ3xrc8aalqXQ7wb2T4MF0Bqwm ieVXqsVeweyEuAhNQXBQsmjh+MDWtpcD9ZZEM11LGjiOuhfNBp4tDHVo6ie9q58A6DGS PQWI3FBVMGXQ9fnsylO/CpkC54B4LIX5EOFQMEbXT+/LPlkTPVSztCfml3v1bSkGdGwu FDaw== X-Received: by 10.42.190.74 with SMTP id dh10mr440635icb.35.1372800899285; Tue, 02 Jul 2013 14:34:59 -0700 (PDT) Received: by 10.64.37.130 with HTTP; Tue, 2 Jul 2013 14:34:19 -0700 (PDT) In-Reply-To: <20130702205143.GC9161@serenity.lan> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: John Keeping wrote: > I have to say that I don't think this is a particularly useful review, > you seem to have skipped huge portions of the code and spent a lot of > time making us read your thought process rather than providing > constructive feedback. What feedback there is mostly seems to be > expressions of disgust rather than actionable points. Well, ignore it then. I'm sorry for having wasted your time. I did what I could in the time I was willing to spend reading it.