From: Ramkumar Ramachandra <artagnon@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Git List" <git@vger.kernel.org>, "Nguyễn Thái Ngọc" <pclouds@gmail.com>
Subject: Re: [PATCH] editor: use canonicalized absolute path
Date: Mon, 29 Jul 2013 21:37:15 +0530 [thread overview]
Message-ID: <CALkWK0=dGmMkgvaNV27E3Pb3+SWSZ2pNMOr-wsEcUR_wgLjMFA@mail.gmail.com> (raw)
In-Reply-To: <7v8v0p2z45.fsf@alter.siamese.dyndns.org>
Junio C Hamano wrote:
> That's a bit strange---the patch text looks like the "how about
> this" patch Duy posted earlier. Shouldn't it be From: Duy with
> S-o-b: by two of you instead?
Feel free to amend as you see fit, as always.
> For editors that are not broken, this could be an annoying
> regression, isn't it? When the user asks "What is the path of the
> file I am editing?" to the editor (i.e. an equivalent of \C-x\C-b),
> the updated code will start spewing a long full-path from the root
> directory, while we used to give a relative path that is short,
> sweet and more in line with the context of user's work.
Does it matter for COMMIT_EDITMSG or other files in $GITDIR? If
you're concerned about it, we can change the logic to: real_path() if
path-is-relative to avoid mangling the path in the non-submodules
case; in the submodules case, it will use an absolute-path, as before.
next prev parent reply other threads:[~2013-07-29 16:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-28 16:59 [PATCH] editor: use canonicalized absolute path Ramkumar Ramachandra
2013-07-29 10:03 ` Duy Nguyen
2013-07-29 14:56 ` Junio C Hamano
2013-07-29 16:07 ` Ramkumar Ramachandra [this message]
2013-07-29 17:29 ` Junio C Hamano
2013-07-29 17:48 ` Ramkumar Ramachandra
2013-07-29 19:40 ` Junio C Hamano
2013-07-30 0:27 ` Duy Nguyen
2013-07-30 13:48 ` Junio C Hamano
2013-07-30 10:21 ` Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALkWK0=dGmMkgvaNV27E3Pb3+SWSZ2pNMOr-wsEcUR_wgLjMFA@mail.gmail.com' \
--to=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).