From: Ramkumar Ramachandra <artagnon@gmail.com>
To: Git List <git@vger.kernel.org>
Cc: Eric Wong <normalperson@yhbt.net>
Subject: Re: [PATCH] Git::SVN: handle missing ref_id case correctly
Date: Sat, 10 Jan 2015 10:12:23 -0500 [thread overview]
Message-ID: <CALkWK0=jEh06hZSmHim54BaP_KiC8hg-455STQphu17PSoQTqw@mail.gmail.com> (raw)
In-Reply-To: <1420900510-78522-1-git-send-email-artagnon@gmail.com>
Ramkumar Ramachandra wrote:
> -our $default_ref_id = $ENV{GIT_SVN_ID} || 'git-svn';
> +our $default_ref_id = defined $ENV{GIT_SVN_ID} ? $ENV{GIT_SVN_ID} : 'git-svn';
This is probably not a functional change; please look at the second hunk.
next prev parent reply other threads:[~2015-01-10 15:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-10 14:35 [PATCH] Git::SVN: handle missing ref_id case correctly Ramkumar Ramachandra
2015-01-10 15:12 ` Ramkumar Ramachandra [this message]
2015-01-10 22:13 ` Eric Wong
2015-01-10 22:14 ` Ramkumar Ramachandra
2015-01-10 22:18 ` Ramkumar Ramachandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALkWK0=jEh06hZSmHim54BaP_KiC8hg-455STQphu17PSoQTqw@mail.gmail.com' \
--to=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=normalperson@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).