From: Ramkumar Ramachandra <artagnon@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: [PATCH v3 2/4] completion: introduce __gitcomp_nl_append ()
Date: Sun, 5 Jan 2014 15:36:21 +0530 [thread overview]
Message-ID: <CALkWK0=rrcTFdpymGB5QJhdLhYvm4FLMGurqugbCGvAdDKVhqA@mail.gmail.com> (raw)
In-Reply-To: <xmqq38l4n6h9.fsf@gitster.dls.corp.google.com>
Junio C Hamano wrote:
> Is it because going this route and doing it at such a low level
> would make zsh completion (which I have no clue about ;-)
> unnecessarily complex?
The zsh completion only cares to override __gitcomp_nl () and
__gitcomp_nl_append (), without bothering to re-implement the
lower-level functions; so it's no problem at all. I wrote mine out by
thinking of a non-intrusive direct translation, while your version
focuses on eliminating duplication. I don't have a strong preference
either way, so I will resubmit with your version.
next prev parent reply other threads:[~2014-01-05 10:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-03 19:56 [PATCH v3 0/4] Fix branch.autosetup(merge|rebase) completion Ramkumar Ramachandra
2014-01-03 19:56 ` [PATCH v3 1/4] completion: prioritize ./git-completion.bash Ramkumar Ramachandra
2014-01-03 19:57 ` [PATCH v3 2/4] completion: introduce __gitcomp_nl_append () Ramkumar Ramachandra
2014-01-03 20:41 ` Junio C Hamano
2014-01-05 10:06 ` Ramkumar Ramachandra [this message]
2014-01-03 19:57 ` [PATCH v3 3/4] completion: fix branch.autosetup(merge|rebase) Ramkumar Ramachandra
2014-01-03 19:57 ` [PATCH v3 4/4] completion: fix remote.pushdefault Ramkumar Ramachandra
2014-01-03 21:21 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALkWK0=rrcTFdpymGB5QJhdLhYvm4FLMGurqugbCGvAdDKVhqA@mail.gmail.com' \
--to=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).