git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ramkumar Ramachandra <artagnon@gmail.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: "Junio C Hamano" <gitster@pobox.com>,
	"Git List" <git@vger.kernel.org>,
	"Nguyễn Thái Ngọc" <pclouds@gmail.com>
Subject: Re: [PATCH 0/3] avoiding unintended consequences of git_path() usage
Date: Wed, 16 Nov 2011 14:21:46 +0530	[thread overview]
Message-ID: <CALkWK0kPM1S9ELTWL1SiGjFN1e3NK2V-q4ixqM77aUMuDPxdqg@mail.gmail.com> (raw)
In-Reply-To: <20111116075955.GB13706@elie.hsd1.il.comcast.net>

Hi Jonathan,

Jonathan Nieder wrote:
> Ramkumar Ramachandra wrote:
>> Junio C Hamano wrote:
>
>>> Or perhaps http://thread.gmane.org/gmane.comp.version-control.git/184963/focus=185436
>>
>> I noticed that sha1_to_hex() also operates like this.  The
>> resolve_ref() function is really important, but using the same
>> technique for these tiny functions is probably an overkill
>
> I don't follow.  Do you mean that not being confusing is overkill,
> because the function is small that no one will bother to look up the
> right semantics?  Wait, that sentence didn't come out the way I
> wanted. ;-)

I meant overkill in terms of the work required and code churn.
Ofcourse, I'd have been more than happy to see it being implemented-
and you've actually done it now! :) Nguyễn has a more fancy solution,
though I'm quite happy with this as it is.

Finally, for all the times I've fumbled in git_path() usage:
Liked-by: Ramkumar Ramachandra <artagnon@gmail.com>

Thanks for working on this.

-- Ram

  parent reply	other threads:[~2011-11-16  8:52 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-05 16:29 [PATCH 0/5] Sequencer: working around historical mistakes Ramkumar Ramachandra
2011-11-05 16:29 ` [PATCH 1/5] sequencer: factor code out of revert builtin Ramkumar Ramachandra
2011-11-06  0:12   ` Jonathan Nieder
2011-11-13 10:40     ` Ramkumar Ramachandra
2011-11-13 23:10       ` Junio C Hamano
2011-11-15  9:00         ` Ramkumar Ramachandra
2011-11-15  9:18           ` Miles Bader
2011-11-15  9:47             ` Jonathan Nieder
2011-11-05 16:29 ` [PATCH 2/5] sequencer: remove CHERRY_PICK_HEAD with sequencer state Ramkumar Ramachandra
2011-11-06  0:15   ` Jonathan Nieder
2011-11-05 16:29 ` [PATCH 3/5] sequencer: sequencer state is useless without todo Ramkumar Ramachandra
2011-11-06  0:26   ` Jonathan Nieder
2011-11-13 10:44     ` Ramkumar Ramachandra
2011-11-13 20:50       ` Junio C Hamano
2011-11-15  9:13         ` Ramkumar Ramachandra
2011-11-15  9:52           ` Jonathan Nieder
2011-11-15 16:27             ` Junio C Hamano
2011-11-16  6:17               ` Ramkumar Ramachandra
2011-11-16  7:38                 ` Junio C Hamano
2011-11-16  7:59                 ` [PATCH 0/3] avoiding unintended consequences of git_path() usage Jonathan Nieder
2011-11-16  8:03                   ` [PATCH 1/3] do not let git_path clobber errno when reporting errors Jonathan Nieder
2011-11-16  8:04                   ` [PATCH 2/3] Bigfile: dynamically allocate buffer for marks file name Jonathan Nieder
2011-11-16  8:07                   ` [PATCH 3/3] rename git_path() to git_path_unsafe() Jonathan Nieder
2011-11-17  1:20                     ` Junio C Hamano
2011-11-17  7:03                       ` Jonathan Nieder
2011-11-16  8:37                   ` [PATCH 0/3] avoiding unintended consequences of git_path() usage Nguyen Thai Ngoc Duy
2011-11-16  8:42                     ` Nguyen Thai Ngoc Duy
2011-11-16  8:59                     ` Jonathan Nieder
2011-11-16  9:31                       ` Nguyen Thai Ngoc Duy
2011-11-19 19:25                         ` Ramsay Jones
2011-11-16 21:50                       ` [PATCH/RFC] introduce strbuf_addpath() Jonathan Nieder
2011-11-18  1:42                         ` Nguyen Thai Ngoc Duy
2011-11-16 22:04                     ` [PATCH 0/3] avoiding unintended consequences of git_path() usage Junio C Hamano
2011-11-16  8:51                   ` Ramkumar Ramachandra [this message]
2011-11-16 13:33                   ` Nguyen Thai Ngoc Duy
2011-11-16 13:44                     ` Michael Haggerty
2011-11-18  3:33                   ` Nguyen Thai Ngoc Duy
2011-11-05 16:29 ` [PATCH 4/5] sequencer: handle single commit pick separately Ramkumar Ramachandra
2011-11-06  0:35   ` Jonathan Nieder
2011-11-05 16:29 ` [PATCH 5/5] sequencer: revert d3f4628e Ramkumar Ramachandra
2011-11-06  0:42   ` Jonathan Nieder
2011-11-06 19:10     ` Junio C Hamano
2011-11-07  6:06       ` Ramkumar Ramachandra
2011-11-12 16:13     ` Ramkumar Ramachandra
2011-11-12 22:40       ` Jonathan Nieder
2011-11-05 23:43 ` [PATCH 0/5] Sequencer: working around historical mistakes Jonathan Nieder
2011-11-13 10:42   ` Ramkumar Ramachandra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALkWK0kPM1S9ELTWL1SiGjFN1e3NK2V-q4ixqM77aUMuDPxdqg@mail.gmail.com \
    --to=artagnon@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jrnieder@gmail.com \
    --cc=pclouds@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).