From: Ramkumar Ramachandra <artagnon@gmail.com>
To: Miklos Vajna <vmiklos@suse.cz>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH v2] cherry-pick: make sure all input objects are commits
Date: Thu, 11 Apr 2013 17:12:06 +0530 [thread overview]
Message-ID: <CALkWK0kb+2KZLvRJDJb_VrNNs1k4grsfyFv0HfYv0Kr9v4sChQ@mail.gmail.com> (raw)
In-Reply-To: <20130411110324.GD12770@suse.cz>
Miklos Vajna wrote:
> I guess that is a should-not-happen category. parse_args() calls
> setup_revisions(), and that will already die() if the argument is not a
> valid object at all.
Then why do you have an if() guarding the code? In my opinion, you
should have an else-clause that die()s with an appropriate message.
> Yes. If you would want, I could of course add test cases for two other
> cases when we already errored out and now the error message is just
> changed, but I don't think duplicating the error message strings from
> the code to the testsuite is really wanted. :-)
Nope, I'd never suggest that: this is fine. What I meant is: you
should clarify that you're fixing a bug and adding a test to guard it,
in the commit message.
next prev parent reply other threads:[~2013-04-11 11:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-03 9:27 [PATCH] cherry-pick: better error message when the parameter is a non-commit Miklos Vajna
2013-04-08 12:27 ` Miklos Vajna
2013-04-08 16:45 ` Junio C Hamano
2013-04-08 16:56 ` Junio C Hamano
2013-04-11 9:26 ` [PATCH v2] cherry-pick: make sure all input objects are commits Miklos Vajna
2013-04-11 10:22 ` Ramkumar Ramachandra
2013-04-11 11:03 ` Miklos Vajna
2013-04-11 11:42 ` Ramkumar Ramachandra [this message]
2013-04-11 13:06 ` [PATCH v3] " Miklos Vajna
2013-04-11 13:27 ` Ramkumar Ramachandra
2013-04-15 8:44 ` Thomas Rast
2013-04-15 18:29 ` Junio C Hamano
2013-04-15 19:12 ` Junio C Hamano
2013-04-16 14:22 ` Michael Haggerty
2013-05-09 19:47 ` Junio C Hamano
2013-05-09 20:27 ` Junio C Hamano
2013-05-10 7:07 ` Miklos Vajna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALkWK0kb+2KZLvRJDJb_VrNNs1k4grsfyFv0HfYv0Kr9v4sChQ@mail.gmail.com \
--to=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=vmiklos@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).