* [PATCH] contrib/remote-helpers: setup ui.username in test-hg.sh
@ 2012-11-11 10:41 Ramkumar Ramachandra
2012-11-11 12:39 ` Felipe Contreras
0 siblings, 1 reply; 3+ messages in thread
From: Ramkumar Ramachandra @ 2012-11-11 10:41 UTC (permalink / raw)
To: Git List; +Cc: Felipe Contreras, Jeff King
test-hg.sh forgets to set ui.username, which is required for `hg
commit`. Fix this.
Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
---
Squash this into fc/remote-hg in pu?
contrib/remote-helpers/test-hg.sh | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/contrib/remote-helpers/test-hg.sh
b/contrib/remote-helpers/test-hg.sh
index 40e6e3c..031dcbd 100755
--- a/contrib/remote-helpers/test-hg.sh
+++ b/contrib/remote-helpers/test-hg.sh
@@ -29,6 +29,15 @@ check () {
test_cmp expected actual
}
+setup () {
+ (
+ echo "[ui]"
+ echo "username = A U Thor <author@example.com>"
+ ) >> "$HOME"/.hgrc
+}
+
+setup
+
test_expect_success 'cloning' '
test_when_finished "rm -rf gitrepo*" &&
--
1.7.12.1.428.g652398a.dirty
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] contrib/remote-helpers: setup ui.username in test-hg.sh
2012-11-11 10:41 [PATCH] contrib/remote-helpers: setup ui.username in test-hg.sh Ramkumar Ramachandra
@ 2012-11-11 12:39 ` Felipe Contreras
2012-11-11 12:50 ` Ramkumar Ramachandra
0 siblings, 1 reply; 3+ messages in thread
From: Felipe Contreras @ 2012-11-11 12:39 UTC (permalink / raw)
To: Ramkumar Ramachandra; +Cc: Git List, Jeff King
On Sun, Nov 11, 2012 at 11:41 AM, Ramkumar Ramachandra
<artagnon@gmail.com> wrote:
> test-hg.sh forgets to set ui.username, which is required for `hg
> commit`. Fix this.
Hmm, I get 'no username found, using 'felipec@nysa' instead', but
everything works fine.
Doesn't hurt to do that though.
Cheers.
--
Felipe Contreras
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] contrib/remote-helpers: setup ui.username in test-hg.sh
2012-11-11 12:39 ` Felipe Contreras
@ 2012-11-11 12:50 ` Ramkumar Ramachandra
0 siblings, 0 replies; 3+ messages in thread
From: Ramkumar Ramachandra @ 2012-11-11 12:50 UTC (permalink / raw)
To: Felipe Contreras; +Cc: Git List, Jeff King
Felipe Contreras wrote:
> On Sun, Nov 11, 2012 at 11:41 AM, Ramkumar Ramachandra
> <artagnon@gmail.com> wrote:
>> test-hg.sh forgets to set ui.username, which is required for `hg
>> commit`. Fix this.
>
> Hmm, I get 'no username found, using 'felipec@nysa' instead', but
> everything works fine.
I get:
abort: no username supplied (see "hg help config")
And the test aborts.
Ram
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-11-11 12:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-11 10:41 [PATCH] contrib/remote-helpers: setup ui.username in test-hg.sh Ramkumar Ramachandra
2012-11-11 12:39 ` Felipe Contreras
2012-11-11 12:50 ` Ramkumar Ramachandra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).