From: Ramkumar Ramachandra <artagnon@gmail.com>
To: Duy Nguyen <pclouds@gmail.com>
Cc: Jeff King <peff@peff.net>, Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 3/4] cat-file: add --batch-disk-sizes option
Date: Mon, 8 Jul 2013 17:30:21 +0530 [thread overview]
Message-ID: <CALkWK0ktNK49zBM4tD8fpNN3VMan7DegfWRtDcOEgTyEbSK9Uw@mail.gmail.com> (raw)
In-Reply-To: <CACsJy8A8ZO3DL8Vr=S1G-3yiJz3WaZ-7jV_eA+v6rPAWrd9NAw@mail.gmail.com>
Duy Nguyen wrote:
> Ram, are you still interested in the awesome branch series?
Yep, but it got stalled due to lack of reviewer-interest :/
I'm a bit under the weather at the moment, but it's good to see that
you're back: let's finish this soon.
>>> Perhaps we need
>>>
>>> git cat-file --batch-format="%(disk-size) %(object)"
>>>
>>> or similar.
>
> This is what I wanted to do with the in for-each-ref's pretty
> formatting [1]. I used to hack cat-file --batch to extract info I
> needed for experimenting with various pack index extensions. If you
> are not in hurry, maybe we can introduce something similar to your
> syntax, but applicable for all for-each-ref, branch and log family.
I'm still quite confused about this "grand plan". We have short
commit-specific format specifiers that don't work with refs, among
several other quirks in [1]. I personally think we should absolutely
stay away from short format-specifiers (like %H, %f, %e; we'll soon
run out of letters, and nobody can tell what they are without the
documentation anyway) for the new options, and just start adding new
long-form ones as and when they are necessary. I think refname:short,
upstream:track, upstream:trackshort are very sensible choices, and
that we should continue along that line. I'm fine with
format-specifiers having meanings only in certain contexts as long as
we document it properly (how can we possibly get %(refname) to mean
something sensible in cat-file?).
As far as this series is concerned, I think Peff can implement %H and
%(object:[disk-]size) locally without worrying about code-sharing or
waiting for us. Then, after the for-each-ref-pretty thing matures, we
can just replace the code underneath.
next prev parent reply other threads:[~2013-07-08 12:01 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-07 10:01 [RFC/PATCH 0/4] cat-file --batch-disk-sizes Jeff King
2013-07-07 10:03 ` [PATCH 1/4] zero-initialize object_info structs Jeff King
2013-07-07 17:34 ` Junio C Hamano
2013-07-07 10:04 ` [PATCH 2/4] teach sha1_object_info_extended a "disk_size" query Jeff King
2013-07-07 10:09 ` [PATCH 3/4] cat-file: add --batch-disk-sizes option Jeff King
2013-07-07 17:49 ` Junio C Hamano
2013-07-07 18:19 ` Jeff King
2013-07-08 11:04 ` Duy Nguyen
2013-07-08 12:00 ` Ramkumar Ramachandra [this message]
2013-07-08 13:13 ` Duy Nguyen
2013-07-08 13:37 ` Ramkumar Ramachandra
2013-07-09 2:55 ` Duy Nguyen
2013-07-09 10:32 ` Ramkumar Ramachandra
2013-07-10 11:16 ` Jeff King
2013-07-08 16:40 ` Junio C Hamano
2013-07-10 11:04 ` Jeff King
2013-07-11 16:35 ` Junio C Hamano
2013-07-07 21:15 ` brian m. carlson
2013-07-10 10:57 ` Jeff King
2013-07-07 10:14 ` [PATCH 4/4] pack-revindex: radix-sort the revindex Jeff King
2013-07-07 23:52 ` Shawn Pearce
2013-07-08 7:57 ` Jeff King
2013-07-08 15:38 ` Shawn Pearce
2013-07-08 20:50 ` Brandon Casey
2013-07-08 21:35 ` Brandon Casey
2013-07-10 10:57 ` Jeff King
2013-07-10 10:52 ` Jeff King
2013-07-10 11:34 ` [PATCHv2 00/10] cat-file formats/on-disk sizes Jeff King
2013-07-10 11:35 ` [PATCH 01/10] zero-initialize object_info structs Jeff King
2013-07-10 11:35 ` [PATCH 02/10] teach sha1_object_info_extended a "disk_size" query Jeff King
2013-07-10 11:36 ` [PATCH 03/10] t1006: modernize output comparisons Jeff King
2013-07-10 11:38 ` [PATCH 04/10] cat-file: teach --batch to stream blob objects Jeff King
2013-07-10 11:38 ` [PATCH 05/10] cat-file: refactor --batch option parsing Jeff King
2013-07-10 11:45 ` [PATCH 06/10] cat-file: add --batch-check=<format> Jeff King
2013-07-10 11:57 ` Eric Sunshine
2013-07-10 14:51 ` Ramkumar Ramachandra
2013-07-11 11:24 ` Jeff King
2013-07-10 11:46 ` [PATCH 07/10] cat-file: add %(objectsize:disk) format atom Jeff King
2013-07-10 11:48 ` [PATCH 08/10] cat-file: split --batch input lines on whitespace Jeff King
2013-07-10 15:29 ` Ramkumar Ramachandra
2013-07-11 11:36 ` Jeff King
2013-07-11 17:42 ` Junio C Hamano
2013-07-11 20:45 ` [PATCHv3 " Jeff King
2013-07-10 11:50 ` [PATCH 09/10] pack-revindex: use unsigned to store number of objects Jeff King
2013-07-10 11:55 ` [PATCH 10/10] pack-revindex: radix-sort the revindex Jeff King
2013-07-10 12:00 ` Jeff King
2013-07-10 13:17 ` Ramkumar Ramachandra
2013-07-11 11:03 ` Jeff King
2013-07-10 17:10 ` Brandon Casey
2013-07-11 11:17 ` Jeff King
2013-07-11 12:16 ` [PATCHv3 " Jeff King
2013-07-11 21:12 ` Brandon Casey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALkWK0ktNK49zBM4tD8fpNN3VMan7DegfWRtDcOEgTyEbSK9Uw@mail.gmail.com \
--to=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).