From: Ramkumar Ramachandra <artagnon@gmail.com>
To: Benoit Sigoure <tsunanet@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Fix compilation on OS X.
Date: Sat, 20 Jul 2013 13:25:09 +0530 [thread overview]
Message-ID: <CALkWK0m46SR3C6R_pjYouu7LkHjL_gPGb1A3S94d0nx8227-UA@mail.gmail.com> (raw)
In-Reply-To: <1374306567-16640-1-git-send-email-tsunanet@gmail.com>
Benoit Sigoure wrote:
> diff --git a/compat/unsetenv.c b/compat/unsetenv.c
> index 4ea1856..addf3dc 100644
> --- a/compat/unsetenv.c
> +++ b/compat/unsetenv.c
> @@ -1,5 +1,10 @@
> #include "../git-compat-util.h"
>
> +#ifdef __APPLE__
> +// On OS X libc headers don't define this symbol.
> +extern char **environ;
> +#endif
> +
Shouldn't this go into git-compat-util.h, since there may be other
files depending on this variable?
next prev parent reply other threads:[~2013-07-20 7:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-20 7:49 [PATCH] Fix compilation on OS X Benoit Sigoure
2013-07-20 7:55 ` Ramkumar Ramachandra [this message]
2013-07-20 7:56 ` tsuna
2013-07-20 12:06 ` Torsten Bögershausen
2013-07-20 18:41 ` Benoit Sigoure
2013-07-21 5:53 ` Junio C Hamano
2013-07-21 6:10 ` tsuna
2013-07-21 6:17 ` [PATCH] Revert "compat/unsetenv.c: Fix a sparse warning" Benoit Sigoure
2013-07-21 19:54 ` Benoit Sigoure
2013-07-21 22:09 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALkWK0m46SR3C6R_pjYouu7LkHjL_gPGb1A3S94d0nx8227-UA@mail.gmail.com \
--to=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=tsunanet@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).