From: Ramkumar Ramachandra <artagnon@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: [PATCH 4/6] stash: introduce 'git stash store'
Date: Mon, 13 May 2013 22:45:02 +0530 [thread overview]
Message-ID: <CALkWK0mQhzrndaEp28nOpLs5STq136PY8hntCpX5RUZKrdJVAA@mail.gmail.com> (raw)
In-Reply-To: <7v61ymop61.fsf@alter.siamese.dyndns.org>
Junio C Hamano wrote:
> git stash store [-m <message>] [-e <error message>] $stash_sha1
1. The message is NOT optional. If the user says 'git stash store
b8bb3fe9', what "default message" can we possibly put in? There is
absolutely no context: no branch name, nothing. So, the best we can
do is "generic WIP". What is the point of putting in such a useless
message?
2. We have already determined that the command is NOT for end user
interactive use. So, why do we need a default error message at all?
The last statement is an update-ref, and you can infer whether it
succeeded or failed from the exit status.
3. Why are we designing a command-line interface? git stash store
"$stash_sha1" "$message" is sufficient for scripts, and there is
absolutely no point in parsing '-m', '-e', or any such thing.
next prev parent reply other threads:[~2013-05-13 17:15 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-13 12:45 [PATCH 0/6] Get stash to help rebase.autostash Ramkumar Ramachandra
2013-05-13 12:45 ` [PATCH 1/6] Documentation/stash: correct synopsis for create Ramkumar Ramachandra
2013-05-13 12:45 ` [PATCH 2/6] Documentation/stash: document short form -p in synopsis Ramkumar Ramachandra
2013-05-13 12:45 ` [PATCH 3/6] stash: simplify option parser for create Ramkumar Ramachandra
2013-05-13 14:34 ` Junio C Hamano
2013-05-13 14:59 ` Ramkumar Ramachandra
2013-05-13 12:45 ` [PATCH 4/6] stash: introduce 'git stash store' Ramkumar Ramachandra
2013-05-13 14:40 ` Junio C Hamano
2013-05-13 15:02 ` Ramkumar Ramachandra
2013-05-13 15:49 ` Junio C Hamano
2013-05-13 17:15 ` Ramkumar Ramachandra [this message]
2013-05-13 17:29 ` Junio C Hamano
2013-05-13 18:09 ` Ramkumar Ramachandra
2013-05-13 18:35 ` Junio C Hamano
2013-05-13 18:45 ` Ramkumar Ramachandra
2013-05-13 19:16 ` Junio C Hamano
2013-05-13 19:25 ` Ramkumar Ramachandra
2013-05-13 18:15 ` Ramkumar Ramachandra
2013-05-13 12:45 ` [PATCH 5/6] stash: tweak error message in store_stash () Ramkumar Ramachandra
2013-05-13 14:42 ` Junio C Hamano
2013-05-13 12:45 ` [PATCH 6/6] rebase: use 'git stash store' to simplify logic Ramkumar Ramachandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALkWK0mQhzrndaEp28nOpLs5STq136PY8hntCpX5RUZKrdJVAA@mail.gmail.com \
--to=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).