From: Ramkumar Ramachandra <artagnon@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jens Lehmann <Jens.Lehmann@web.de>,
Git List <git@vger.kernel.org>, Jeff King <peff@peff.net>
Subject: Re: Composing git repositories
Date: Wed, 27 Mar 2013 22:32:27 +0530 [thread overview]
Message-ID: <CALkWK0nARWAtC-D3UiNLccuaSwjR6meJb+Cu590N=8Ti8O7OMg@mail.gmail.com> (raw)
In-Reply-To: <7vvc8comj5.fsf@alter.siamese.dyndns.org>
Junio C Hamano wrote:
> Ramkumar Ramachandra <artagnon@gmail.com> writes:
>> Junio C Hamano wrote:
>>> So you have to stash it somewhere. We could have made it to move
>>> them to $HOME/.safeplace or somewhere totally unrelated to the
>>> superproject. So in that sense, the repositories are *not* owned by
>>> the superproject in any way. However, you are working within the
>>> context of the superproject on the submodule after all, and
>>> somewhere under $GIT_DIR/ of the superorject is not too wrong a
>>> place to use as such a safe place.
>>
>> Thanks for the explanation.
>
> What do you _exactly_ mean by that? You understood why things are
> arranged in that way, and no longer think that it is unnecessary,
> ugly and unwieldy to stash the real copy of $GIT_DIR of submodules
> away from their working trees and store them inside $GIT_DIR/modules
> of the superproject?
In essence, git commands are built to act on pure worktrees. It's
trivially Correct to pretend that an object store present in the
toplevel directory (as .git/) of the worktree doesn't exist, but it's
quite non-trivial to handle a .git directory anywhere else in the
worktree. Since we built git ground-up to act on a single
repository's worktree, embedding one repository inside another is a
hack: as a "workaround", we simply relocate the object store of the
submodule repository. Even then, working with one worktree embedded
inside another is something git never designed for: it explains why I
have to literally fight with git when using submodules (no offense
Jens; it's a very hard problem).
Representing submodules as commit objects in the tree is also a hack.
I'm sorry, but a submodule is not a commit object. We need a fifth
object type if we want them to be first-class citizens.
Sorry, I'm deviating. I learnt why you think the hack is necessary
and not "too wrong". As I explained above, the entire design is
asymmetric and inelegant; I think we can do much better than this.
next prev parent reply other threads:[~2013-03-27 17:03 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-26 7:56 Composing git repositories Ramkumar Ramachandra
2013-03-26 16:39 ` Junio C Hamano
2013-03-27 11:49 ` Ramkumar Ramachandra
2013-03-27 16:06 ` Junio C Hamano
2013-03-27 17:02 ` Ramkumar Ramachandra [this message]
2013-03-27 17:16 ` Junio C Hamano
2013-03-27 19:26 ` Jonathan Nieder
2013-03-27 20:18 ` Junio C Hamano
2013-03-27 20:42 ` Jonathan Nieder
2013-03-28 11:48 ` Ramkumar Ramachandra
2013-03-28 20:25 ` Jens Lehmann
2013-03-28 10:01 ` Ramkumar Ramachandra
2013-03-28 18:21 ` Jonathan Nieder
2013-03-28 20:17 ` Jens Lehmann
2013-03-27 23:02 ` Jens Lehmann
2013-03-28 9:16 ` Ramkumar Ramachandra
2013-03-28 20:40 ` Jens Lehmann
2013-03-31 20:34 ` Ramkumar Ramachandra
2013-03-31 22:57 ` Jonathan Nieder
2013-04-02 17:44 ` Ramkumar Ramachandra
2013-04-02 17:58 ` Jeff King
2013-04-02 19:33 ` Ramkumar Ramachandra
2013-04-02 19:56 ` Jens Lehmann
2013-04-02 18:03 ` Junio C Hamano
2013-04-04 6:40 ` Junio C Hamano
2013-04-05 2:36 ` Duy Nguyen
2013-04-05 4:53 ` Junio C Hamano
2013-04-05 5:27 ` Duy Nguyen
2013-04-05 7:15 ` Jens Lehmann
2013-03-31 23:50 ` Phil Hord
2013-04-01 12:14 ` Jens Lehmann
2013-04-01 14:49 ` Phil Hord
2013-04-02 18:35 ` Ramkumar Ramachandra
2013-04-02 18:54 ` Jonathan Nieder
2013-04-02 19:09 ` Junio C Hamano
2013-04-02 19:11 ` Ramkumar Ramachandra
2013-04-02 19:20 ` Jonathan Nieder
2013-04-02 19:29 ` Ramkumar Ramachandra
2013-04-02 19:49 ` Ramkumar Ramachandra
2013-04-02 19:59 ` Jens Lehmann
2013-04-01 9:50 ` Jens Lehmann
2013-04-01 0:16 ` Seth Robertson
2013-04-02 19:19 ` Ramkumar Ramachandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALkWK0nARWAtC-D3UiNLccuaSwjR6meJb+Cu590N=8Ti8O7OMg@mail.gmail.com' \
--to=artagnon@gmail.com \
--cc=Jens.Lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).