git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ramkumar Ramachandra <artagnon@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Phil Hord <phil.hord@gmail.com>, Git List <git@vger.kernel.org>
Subject: Re: [PATCH] diffcore-pickaxe doc: document -S and -G properly
Date: Wed, 15 May 2013 01:32:45 +0530	[thread overview]
Message-ID: <CALkWK0nT-0LG2jaM+Y2R6+brYeFTuPsoDT+R17Ag_jnEwee32Q@mail.gmail.com> (raw)
In-Reply-To: <7vd2stibix.fsf@alter.siamese.dyndns.org>

Junio C Hamano wrote:
> When a commit moves a file wholesale without affecting the block of
> code you are interested in, you know that whole block came from the
> file in the old tree at pre-rename location without looking at
> anywhere else.  That is why renamed but pickaxe-uninteresting
> filepairs are dropped.
>
> When a commit moves (some lines of) the block of code you are
> interested in from one file to another, it may have been a single
> instance moving to another place, but it may well have been multiple
> copies consolidated into one (the new copy, pickaxe digging from
> future to past may see "disappearing").  That is a significant event
> worth digging into further by first stopping there and then
> inspecting the whole change with --pickaxe-all to see what changes
> that are similar to the change in question exist in the other parts
> (notice the multiple) of the tree.

Makes sense.  I wasn't looking at it from a macro perspective.

Yeah, I constantly re-read 217 and your follow-up.

  reply	other threads:[~2013-05-14 20:03 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-14 14:12 [PATCH] diffcore-pickaxe doc: document -S and -G properly Ramkumar Ramachandra
2013-05-14 17:41 ` Junio C Hamano
2013-05-14 18:20   ` Ramkumar Ramachandra
2013-05-14 18:47     ` Junio C Hamano
2013-05-14 18:57       ` Ramkumar Ramachandra
2013-05-14 19:17         ` Jonathan Nieder
2013-05-14 19:25           ` Ramkumar Ramachandra
2013-05-14 19:29             ` Jonathan Nieder
2013-05-14 19:41               ` Junio C Hamano
2013-05-14 19:31         ` Junio C Hamano
2013-05-14 21:13         ` Phil Hord
2013-05-14 17:44 ` Phil Hord
2013-05-14 17:47   ` Phil Hord
2013-05-14 18:44   ` Ramkumar Ramachandra
2013-05-14 19:19     ` Junio C Hamano
2013-05-14 19:46       ` Ramkumar Ramachandra
2013-05-14 19:53         ` Junio C Hamano
2013-05-14 20:02           ` Ramkumar Ramachandra [this message]
2013-05-14 19:23     ` Phil Hord
2013-05-14 18:57   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALkWK0nT-0LG2jaM+Y2R6+brYeFTuPsoDT+R17Ag_jnEwee32Q@mail.gmail.com \
    --to=artagnon@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=phil.hord@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).