git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ramkumar Ramachandra <artagnon@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: [PATCH 0/2] Fix invalid revision error messages for 1.8.3
Date: Tue, 21 May 2013 23:20:48 +0530	[thread overview]
Message-ID: <CALkWK0nXbncV4bjHLSQCu21w36vQP5E9irNhBbyXoEZ4-oqfcQ@mail.gmail.com> (raw)
In-Reply-To: <7vy5b8p9wm.fsf@alter.siamese.dyndns.org>

Junio C Hamano wrote:
> Fixes to something that are broken the same way between 'master' and
> older release versions are the same as enhancements (which you can
> view as "fix to lack of feature").  They are not regression fixes
> and not for 1.8.3 at this point in the cycle, deep into -rc.

If we view them as enhancements, well and good.  Let's polish them
until we're really happy with them: they're written with the "minimal,
but correct" philosophy, because the -rc3 window is too small for a
review.

Just to share opinion, they looked like "bugs" to me, because it's not
about "improving" the error messages; it's about correcting a defect.
The author could not have possibly intended two "error: " lines in the
first one, or an empty string in the second one.  At some point in the
past, the behavior must have been different (a "feature" must have
introduced these problems: like implicit HEAD for @{<N>}): the
"regression" was introduced in the version after that.  So, is it
because that version was too long ago that we don't consider it a
regression (do we backport fixes)?

  reply	other threads:[~2013-05-21 17:51 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-21 10:41 [PATCH 0/2] Fix invalid revision error messages for 1.8.3 Ramkumar Ramachandra
2013-05-21 10:41 ` [PATCH 1/2] sha1_name: fix error message for @{u} Ramkumar Ramachandra
2013-05-21 16:42   ` Junio C Hamano
2013-05-21 17:56     ` Ramkumar Ramachandra
2013-05-21 18:02       ` Junio C Hamano
2013-05-21 18:04         ` Ramkumar Ramachandra
2013-05-21 18:09           ` Junio C Hamano
2013-05-21 19:19           ` Ramkumar Ramachandra
2013-05-21 20:08             ` Junio C Hamano
2013-05-21 20:14               ` Ramkumar Ramachandra
2013-05-21 20:33                 ` Junio C Hamano
2013-05-21 10:41 ` [PATCH 2/2] sha1_name: fix error message for @{<N>}, @{<date>} Ramkumar Ramachandra
2013-05-21 16:52   ` Junio C Hamano
2013-05-21 17:38     ` Kevin Bracey
2013-05-21 18:09     ` Ramkumar Ramachandra
2013-05-21 16:36 ` [PATCH 0/2] Fix invalid revision error messages for 1.8.3 Junio C Hamano
2013-05-21 17:50   ` Ramkumar Ramachandra [this message]
2013-05-21 17:57     ` Junio C Hamano
2013-05-21 18:16       ` Ramkumar Ramachandra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALkWK0nXbncV4bjHLSQCu21w36vQP5E9irNhBbyXoEZ4-oqfcQ@mail.gmail.com \
    --to=artagnon@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).